Release Update for Firefox More Often

[StabbarN]

Thanks for the awesome webextension.

Would you mind updating the app on Firefox's addon market more often?

[eejdoowad]

Thanks for the feedback. The next release will be published on Firefox (and fix a few Firefox specific bugs).

I'll also start posting Firefox releases together with chrome releases.

[eejdoowad]

Hi @magnus-staberg. I've just released version 1.11 and published it on chrome and firefox. The turn around time for firefox addons approval is usually long (multiple days to weeks).

Until then, try building Saka Key from version 1.11's commit (https://github.com/lusakasa/saka-key/commit/85e42905c059a212d2c22861e008af903b72e050) by following the instructions in the readme (npm install && npm run build:prod:firefox).

[StabbarN]

Great, thanks :)

I tried building and installing but can't figure out how to install it on Firefox. Firefox wanted a add-on file format but I found none in dist folder.

In firefox I open about:addons and then "Install add-on From File". Is this not the way to install it?

[eejdoowad]

Currently, the easiest way is to navigate to about:debugging, click Load Temporary Add-on, select any file within the generated dist directory, and hit open.

Extensions loaded this way will automatically be removed when you close the browser.

npm run build:firefox generates a build that produces debug logs. npm run build:prod:firefox excludes debug logs and is run through a minifier/optimizer, so it's noticably faster.

[eejdoowad]

Firefox isn't my daily driver, so if you experience any difficulties please let me know.

Firefox bugs I know about:

• Scrolling the options GUI in the popup is broken... so you're better off opening the options GUI in a new tab.
• Only opening links the standard way works. You can't, for example, open links in a background tab.

[StabbarN]

I installed the locally built version, commit 85e4290, but cannot open the settings. the window clicking on the icon is empty and clicking options on info.html resolves to an empty page.

[eejdoowad]

From my experience, that happens when you generate a chrome build by running npm run build instead of npm run build:firefox. Even after you load in the extension, make sure not to run npm run build because firefox uses whatever files exist in the dist directory.

Now that I think about it, I'll remove the commands npm run:buildand npm run:build:prod so you have to explicitly mention the target browser. This will help avoid confusion.

[StabbarN]

I did npm run build:prod:firefox but retried with npm run build:firefox and that seems to be working better.

[eejdoowad]

That's strange. I'll look into it.

[StabbarN]

I've activated Prevent Pages From Stealing Focus. On google it works for the first tapped key but the following keys will be insterted into the search input.

[eejdoowad]

It doesn't seem to work for me at all on google searches. It works fine on google.com

[eejdoowad]

I think the 'Prevent Pages From Stealing Focus' issue, and many others relating to DOM event handling, have been resolved in version 1.14 (the latest commit).

[eejdoowad]

I haven't been able to replicate your issue with loading production builds. I tried a fresh Ubuntu virtual machine with Firefox Developer Edition. Saka Key requires a recent version of Firefox. I advise using Firefox Developer addition.

[StabbarN]

With google searches I meant searching on google.com google.com is working a lot better in latest commit.

I checked out latest commit and successfully built npm run build:prod:firefox.

[eejdoowad]

Great! I made some major architectural changes that should let the Firefox build work much reliably.

[gliptak]

https://addons.mozilla.org/en-US/firefox/addon/saka-key/ still shows version 1.3

If it is very time consuming keep Firefox up-to-date, could you consider offering "release" files (directly in the project)?

Thanks

[eejdoowad]

I apologize for the extended wait for Firefox updates. I submitted an update over a month ago and it's still sitting at 5 of 159 in the approval queue.

Hosting release files is an extra step in the development process that will slow it down (unless I spend time automating it). I figure my users are either: 1) developers who will have no problem following the build instructions in the readme, or 2) general users who won't get further than the firefox marketplace.

It's something l should do eventually, but there are so many other features and fixes I want to implement. Meanwhile, I take care to ensure the master branch always contains a working build. So git pull origin master && npm run build:prod:firefox should always get you the latest release.

[gliptak]

@eejdoowad No need to apologize for somebody else's slow review queue.

[IGI-111]

Have you considered using the beta extension channel for intermediate releases? It doesn't have the approval constrainst and it would still allow for people to get the latest version from the marketplace to test.

[eejdoowad]

@IGI-111 thanks! I had no idea beta channels existed. Firefox users, the beta channel now hosts version 1.18.0. Enjoy!

[gliptak]

The beta channel direct link for current version is https://addons.mozilla.org/firefox/downloads/latest-beta/saka-key/addon-795406-latest.xpi?src=dp-btn-devchannel

Consider closing this issue.