search

lusakasa / saka-key

A keyboard interface to the web
https://key.saka.io
MIT License
860 stars 70 forks source link

NOT READY: New Firefox duplicate background tab fix + version check #337

Open Seanld opened 2 years ago

Seanld commented 2 years ago

A simple fix for the duplicate background tabs problem happening since about Firefox 96, according to this Vimium commit.

This disables the extra click event for Firefox >= 96. However, on Arch Linux (which has the latest Firefox), with Firefox 96, the user agent string is still showing as Firefox 91. So the version check is incorrect. I'm not certain if this happens on more peoples' machines than mine. The reason it did not work for me was because privacy.resistFingerprinting was set to true. Need a workaround for this.

seanjennings960 commented 2 years ago

I'm not certain if this happens on more peoples' machines than mine.

This fixed works for me! Running Firefox 96 on Ubuntu 20.04.

seanjennings960 commented 2 years ago

Noticed that this broke the normal clicking. So I did a bit of snooping since this was bugging me :relieved:. Opened a PR on the personal repo: https://github.com/seanjennings960/saka-key/pull/2