search

lusakasa / saka-key

A keyboard interface to the web
https://key.saka.io
MIT License
862 stars 70 forks source link

Color picker selection is ignored for link hint color settings #61

Open lweberk opened 7 years ago

lweberk commented 7 years ago

Browser Type/Version

FF57 QDevEd

Expected Behaviour

On selection of a color in the color picker when selecting a color for any of foreground, background or border color, it should take the newly specified color as the new set color.

Actual Behaviour

Color selected in color picker gets ignored when pressing any of the dialog's "Select" or "Cancel" buttons.

eejdoowad commented 7 years ago

I use FF57 Dev Edition and the color picker works for me, though it's a little buggy in that I might have to close the picker then manually click on the page before the color updates.

I used the built-in element for color selection because it was so convenient. But it should really be replaced with a custom keyboard-friendly picker.

lweberk commented 7 years ago

Workaround sadly did not work for me.

Edit: maybe I should mention that I'm running a Linux x86_64 build of the FF57 Dev Beta3

eejdoowad commented 7 years ago

The <input type="color"> element is operating system dependent. It's unfortunate that you get a different color picker on every OS. This is another reason a custom implementation is needed.

mejibyte commented 4 years ago

The color picker doesn't work at all for me on Firefox 77.0.1 and Mac OS Catalina (10.15.5). The color picker appears, but when I click on it and select a color, nothing happens.