search

lusakasa / saka-key

A keyboard interface to the web
https://key.saka.io
MIT License
862 stars 70 forks source link

Link hints don't work with non-latin keyboard layout #92

Open f1u77y opened 6 years ago

f1u77y commented 6 years ago

Steps to reproduce

  1. Enable "Bind to physical keys (en-US QWERTY) not characters) setting
  2. Switch to non-latin layout
  3. Open hints
  4. Press some keys which identify some hint

Expected behavior

Link under the hint is pressed as when using latin layout

Current behaviour

Nothing happens

Details

eejdoowad commented 6 years ago

Currently, link hint characters ignore the physical keys setting and always use the characters produced. This is a bug. I just wanted to get something out the door when I implemented this initially.

The fix is to:

  1. Replace the text input for configuring hint characters with a custom UI widget for specifying a set of keys.
  2. Update Hints mode to respect the physical keys setting.

Thanks!