Allow for custom keyboard shortcut

lusakasa / saka

Elegant tab, bookmark and history search

MIT License

215 stars 20 forks source link

Allow for custom keyboard shortcut #7

Closed tnguyen14 closed 5 years ago

tnguyen14 commented 6 years ago

Is it possible to activate this extension using a different keyboard shortcut from Ctrl-Space? That one is already been mapped on my machine for an omnisearch box on the computer.

alexherbo2 commented 6 years ago

Yep, the commands API allows that.

Open chrome://extensions/configureCommands to configure the keyboard shortcuts.

tnguyen14 commented 6 years ago

I am using Firefox 57. Is that available there as well?

alexherbo2 commented 6 years ago

They have a commands API too – which based on Chrome’s one – but I’ve not found how.

eejdoowad commented 6 years ago

Firefox's current state of affairs is confusing. The commands API exists, but only the first keybinding in the manifest file is respected and there's no way for users to configure keybindings. Maybe CMD+E should be the default keybinding on Macs since many users already have ALT+SPACE mapped to something else. The next release of Saka Key will let you configure any key to open Saka on Firefox.

Hope for the future: https://bugzilla.mozilla.org/show_bug.cgi?id=1215061

tnguyen14 commented 6 years ago

Thanks @eejdoowad. Do you know when that release would be?

tnguyen14 commented 6 years ago

And I agree that it should be "Cmd+e" on Mac, and "Ctrl+e" on Windows as well.

eejdoowad commented 6 years ago

As soon as I resolve the issue that corrupts your setting when Saka Key updates on Firefox.

baybatu commented 6 years ago

hi, is there any update on making shortcut cmd+e on Firefox?

pureooze commented 6 years ago

@baybatu this should already work, its set in the manifest:

https://github.com/lusakasa/saka/blob/master/static/manifest.json#L15-L40

chrise86 commented 5 years ago

It does look like command + e should work by looking at src/background_page/index.js, any reason why it wouldn't work?

pureooze commented 5 years ago

It does look like command + e should work by looking at src/background_page/index.js, any reason why it wouldn't work?

Looks like it is fine in chrome but firefox does not seem to work with that hotkey. I will have to look into this, this should work 🤔

pureooze commented 5 years ago

I think Command+E is conflicting with some browser/global hotkey. It seems to work if it gets changed to MacCtrl. I'm not sure why Firefox is not respecting the Ctrl -> Command key mapping.

pureooze commented 5 years ago

Firefox now allows you to customize hotkeys for extensions by selecting "Manage Extension Shortcuts" on the about:addons page. Chrome has allowed this for a while.

Closing this issue as you should now be able to use whatever hotkeys work best on your system.