[FE4] Prince has invalid promotions for similar promotion setting.

[Hozu]

I made a mistake way back when I sent you the list of valid promos for similar promotions. I had not realized the Prince class has a MAG base of 3. This means the only valid promotions for it are Forrest (ie. Hero) and Master Knight. If the unit has at least one minor sword blood, that opens up Paladin (M).

(not actually sure if this is an issue on the latest version, but I don't recall seeing a change for that).

[bobosmith01]

What does the base matter? Can it roll over into negatives or something? Genuinenly curious.

[Hozu]

Class bases that are not HP and luck determine the class cap, since the caps are simply class base + 15. So if Prince promotes into Swordmaster, the unit will lose 3 points of magic. This is not supposed to happen with the similar promotion setting.

[lushen124]

Almost 2 years later, and finally getting to this, lol.

Just to make sure, you mean this list, right?

case PRINCE:
    assert !isFemale : "Princes can only be loosely promoted by males.";
    resultList.addAll(Arrays.asList(LORD_KNIGHT, FORREST_KNIGHT, DRAGON_MASTER, FORREST, SWORD_MASTER, MASTER_KNIGHT));
    if (slot1Blood.contains(HolyBloodSlot1.MINOR_BALDR) || slot1Blood.contains(HolyBloodSlot1.MAJOR_BALDR) ||
            slot2Blood.contains(HolyBloodSlot2.MINOR_OD) || slot2Blood.contains(HolyBloodSlot2.MAJOR_OD) ||
            slot3Blood.contains(HolyBloodSlot3.MINOR_HEZUL) || slot3Blood.contains(HolyBloodSlot3.MAJOR_HEZUL)) {
        resultList.add(PALADIN);
    }
    break;

Only FORREST should be in the universal list, alongside MASTER_KNIGHT.

[Hozu]

Sorry for being many months late, I haven't been paying attention. That does appear to be the correct list, yes. Although looking at it, the list of Prince promos should not have Forrest Knight, Swordmaster, Knight Lord, nor Dragonmaster, as all of those classes have 0 base MAG (Prince has 3). It should have only Forrest (ie. Hero), and Master Knight, and conditionally with any sword blood, Paladin (male), since Prince is male only.