search

lushen124 / Universal-FE-Randomizer

Properly universal this time.
MIT License
98 stars 28 forks source link

[FE7] Randomize Lords crashes when trying to assign palettes #395

Closed isloat closed 1 year ago

isloat commented 2 years ago

image

All other settings not visible in the screenshot are turned off. Turning off Include Lords allows the randomizer to compile without problem. This setting works properly for FE6, so it seems to be a problem specific to FE7.

Geeene commented 1 year ago

Hi,

the issue here is that the randomizer takes the characters from the Map that contains the Randomized Character mapping. This map will not contain Lyn / Eliwood / Hector, if they aren't being randomized. So when the randomizer tries to get them from the map it blows up since it can't find them, and currently only checks that the Map exists, not that the character also is in the map.

Since at this point it is an expected scenario, we should check that if the lords are not in the map, then we just use the default Lyn / Eliwood / Hector character slot, since they aren't randomized.

This way it works: 2022-11-27 16_52_23-Yune - Universal FE Randomizer_src_random_gba_randomizer_GBARandomizer java - Ec

lushen124 commented 1 year ago

Addressed with #400.

isloat commented 1 year ago

Excellent, thank you! Looking forward to the new release.