search

lushen124 / Universal-FE-Randomizer

Properly universal this time.
MIT License
98 stars 28 forks source link

Issue #178 + Proposed Refactor GBA + FE4 Record Keeper #401

Closed Geeene closed 9 months ago

Geeene commented 1 year ago

Contains a fix for Issue #178 to move bosses in GBA FE to their own section, by creating a subcategory "Characters - Bosses", which is pretty much the same thing FE4 does.

Additionally I moved the FE9 ChangeLog related things into their own package (recordkeeper.fe9) and refactored the GBA + FE4 Record Keeper into more of a Builder style like the FE9 one.

I personally prefer the readability as a builder, but if you disagree then I could remove those and only keep the change to the gba/loader/CharacterDataLoader.java

since that's the only thing needed for the defect

lushen124 commented 1 year ago

This is good stuff. I had been wanting to migrate to the newer version of the changelog, but that was pretty low on my priority list since there was already a functional solution, but if we can migrate it sooner, that's better. It does generally read better and is more flexible than the old way. 👍