search

lushen124 / Universal-FE-Randomizer

Properly universal this time.
MIT License
98 stars 28 forks source link

[Issue #408] Added casual mode and options for experience gain rate. #409

Closed lushen124 closed 1 year ago

lushen124 commented 1 year ago

This change adds options for GBA FE to enable casual mode and modify the experience rate between 0.5x, 1x, and 2x. These options can be found in the Miscellaneous section.

Screenshot 2023-03-26 at 3 10 30 PM
Geeene commented 1 year ago

I wanted to test something really quick and noticed this:

As you only set the ui.MiscellaneousView.experienceRate variable in the listeners on the buttons, if you never make a selection then this value is null, leading to an NPE in the GBARandomizer line 2087

2023-04-04 18_34_32-Window

2023-04-04 18_40_51-Yune_ A Universal Fire Emblem Randomizer (v0 9 3)

Obviously once you have ever selected another option here the options bundle fixes this, but it can be reproduced by just setting the bundle version to a random new number

lushen124 commented 1 year ago

Ah, good catch. It looks like I forgot to set the default value up top. Thankfully an easy fix. 🙂