lushen124
commented
1 year ago As the Weapon Ranks were transfered 1-to-1 (just scaled) it didn't actually check that the class of the unit was still able to use all the weapon ranks.
Yeah, there's some logic in randomized recruitment logic that does this transfer. I don't remember if this is the exact logic, but it does something like: take the character's weapon ranks, and map weapon ranks to the target class starting with the highest rank, either going down the list or repeating the rank for each weapon type in the target class.
For example, if you're transferring FE7 Marcus, he starts with rank A, D, and E (the actual types don't matter). If he becomes a Swordmaster, he gets A rank swords. If he becomes a Hero, he gets either A rank Swords and D rank axes, or vice versa. If FE7 Karel (who starts with A rank) becomes a Hero, he'd get A rank swords and axes.
Shuffle in a character that still exists in the current game (i.e. you have the character twice), then replace the original version of the character. The text replacement has no way of knowing which of the texts are the shuffled in and which are the original character.
The original logic in recruitment randomization logic handles this because it collects all of the changes necessary first and then uses Matcher to make sure everything is only updated once.
For example, if you're randomizing FE7 and you re-import Eliwood as Hector's replacement and then import, say, Roy as Eliwood. The logic should generate the regex string:
\b[H-]*Hector\b|\b[E-]*Eliwood\bA real string would link together every name it wants to replace (and the all-caps versions) and be MUCH longer. It then runs through every string and processes it with the Matcher. Matcher processes each regex match once and performs the replacement, so if your string is:
"Hector, you and Eliwood were right!"
Matcher.find() will find "Hector" first and replaces it with "Eliwood". Matcher.find() then proceeds to process "Eliwood" and replaces it with "Roy". At that point, calling Matcher.find() should return false, so it should finish processing that string and move to the next one.
The final string would be:
"Eliwood, you and Roy were right!"
The important part is to make sure the replacement table is complete first before you do any replacing, because the goal is to process each string exactly once.
Geeene
I wanted to try generating a rom with a custom cast for a playthrough that I want to do, and while working on this, I noticed some small issues with the Character Shuffling.
Issue 1:
As the Weapon Ranks were transfered 1-to-1 (just scaled) it didn't actually check that the class of the unit was still able to use all the weapon ranks.
We should make sure that if classRank == 0, then we don't set the rank.
Issue 2: My custom cast contained chars from all three games.
When randomizing I sometimes noticed that some names were incorrect. After some quick analysis, the reason here seems to be as following:
Shuffle in a character that still exists in the current game (i.e. you have the character twice), then replace the original version of the character. The text replacement has no way of knowing which of the texts are the shuffled in and which are the original character.
I'm not yet sure if / how this could be fixed.
I'll also add the program I used to generate the custom cast config from a txt of names. The same function could also be used inside Yune technically, would be a question of how we would want to do it.