lusingander / serie

A rich git commit graph in your terminal, like magic 📚
MIT License
436 stars 13 forks source link

Config directory without `$XDG_CONFIG_HOME` should default to `~/.config/...` #25

Closed uncenter closed 3 months ago

uncenter commented 3 months ago

I was reading through the readme and was quite surprised that if XDG_CONFIG_HOME is not defined the configuration directory is instead ~/.cache/. This seems like an odd choice - XDG_CONFIG_HOME is typically ~/.config/ and serie should probably default to that as well.

alerque commented 3 months ago

Yes definitely.

uncenter commented 3 months ago

I think this must be a typo actually? Looking at the code it seems like it just uses https://docs.rs/xdg/2.5.2/xdg/struct.BaseDirectories.html#method.get_config_file.