search

luskanek / Interact

World of Warcraft (1.12) client mod that brings the Interact key introduced in Dragonflight to Vanilla
MIT License
5 stars 0 forks source link

Feature Request: Exclude Other Player Pets and Include Fishing Bobbers for Interact Key If Possible #3

Closed SamuelR827 closed 5 days ago

SamuelR827 commented 6 days ago

Hello!

First, thank you for implementing the code to ignore player pets when iterating objects! It works perfectly and no longer targets my pet when I’m trying to interact with other objects. This feature has been a huge help.

If possible, I’d love to see similar functionality applied to other player objects. Specifically, when using the interact key, other players themselves seem to be ignored, but their pets and summoned items (like hunter pets or shaman totems) are not. When I’m in a dungeon, I often aim to interact with the nearest enemy to attack, but I end up targeting pets or totems instead. Would it be feasible to extend the same “ignore” behavior to these player-owned objects?

Additionally, would it be possible to include fishing bobbers in the interact key’s range? I imagine this might just involve adjusting the interaction distance, but I’m not sure.

I apologize for asking for multiple features here! I’d be happy to try and contribute, although I’m still getting familiar with the code and the C++ language.

Thank you again for your great work on this project!

luskanek commented 5 days ago

Hello, I've been actually working on this because I keep targeting shaman totems while in a group and it is kinda annoying. So you can expect this to be a feature in the near future.

As for bobbers, it is possible to include them too but I've deliberately chose not to include them for several fair-play reasons. I might think it through again and analyze if it would be truly possible to exploit it (as right now I think it would).

SamuelR827 commented 4 days ago

Thank you for letting me know about your upcoming update for player-owned objects—this is greatly appreciated!

Regarding the fishing bobbers, I hadn’t considered the potential fair play implications of enabling interaction with them. The reason I’m interested in this feature is that I’m currently modifying and creating an addon, based on Right Click by vortigern11 https://github.com/vortigern11/RightClick, which disables right-click targeting. My goal is to reserve right-click functionality exclusively for camera steering and menu navigation.

This setup is especially useful for my Steam Deck, where I have a controller configuration to simulate a right-click when I touch the joystick sensor. This lets me steer the camera by pressing on the joystick. However, this approach sometimes causes unintended targeting or interactions. Disabling right-click targeting with the addon works well overall, but it also prevents right-click interactions with objects. That’s where your mod comes in—it allows me to interact with the world while keeping right-click steering, and it works perfectly except for fishing bobbers.

Either way, thank you again for all your hard work on this! If you have any advice on how I might approach adding fishing bobber interaction on my own, I’d love to hear it.