search

luspi / photoqt

PhotoQt Image Viewer (mirror repo) - https://photoqt.org
GNU General Public License v2.0
49 stars 11 forks source link

Ugly filetype name in Windows #9

Closed LaaZa closed 2 years ago

LaaZa commented 2 years ago

Windows shows rather raw name for filetypes if photoqt is set to handle them.

For example where filetype should be shown as PNG Image or Portable Network Graphics (with older pqt) it is pqt.pngfile instead, similar happens for every filetype that photoqt is set to handle even though those filetypes are not photoqt specific. This name is shown in many different places where a "friendly" name is supposed to be shown, like choosing filetype when saving or in explorer (including thirdparty replacements which use the same string)

filetype_example

save_example

This issue appeared in v2.4, before that the names did change from default windows behaviour, but they did look more friendly. Tested different versions in windows sandbox to make sure it wasn't caused by anything else.

Tested in Windows 11 22000.493.

luspi commented 2 years ago

Hi @LaaZa

My apologies for the late reply. Due to some life events I had to put working on PhotoQt on hold for a few weeks...

Yes, in version 2.4, the filenames were indeed rather ugly on Windows. This should be fixed in the latest version, v2.5.

LaaZa commented 2 years ago

No worries, you can take all the time you need and not like this is a big issue anyway. Keep up the good work.

Sorry if I left it unclear but I was talking about the latest version 2.5, what I meant was that this issue has been since 2.4.

And I reconfirmed just now that it does indeed happen with a clean install of 2.5.(windows sandbox)

luspi commented 2 years ago

Hm, I wonder if I accidentally used an older installer script file when setting up the installer... I'll look into it!

LaaZa commented 2 years ago

I don't think there has been a difference in the related files since 2.4 release, but I'm also not too knowledgeable about that installer stuff.

luspi commented 2 years ago

I just updated the Windows installer to the latest release, v2.6. I tested the installer on a fresh setup of Windows, and the filetype was shown with its "friendly" name. It should unregister and reregister the filetypes on install, so please give it a try and let me know if that worked.

LaaZa commented 2 years ago

Tested and working. Some of the names could be a bit more brief though: image

By default windows shows JPEG Image, and perhaps that would be preferrable for common formats and maybe something more specific if it is rare or application specific format.

Thank you for your hard work. I'll report if I find anything else or have some ideas.