search

lustre-labs / lustre

An Elm-inspired framework for building HTML templates, single page applications, and server-rendered components in Gleam!
https://hexdocs.pm/lustre
MIT License
738 stars 52 forks source link

Add children argument to html.option #68

Closed 0xca551e closed 3 months ago

0xca551e commented 3 months ago

Ref: https://github.com/lustre-labs/lustre/issues/67

hayleigh-dot-dev commented 3 months ago

Hey there, thanks for this! It looks like only text is valid as a child for an <option> element. Can we change the signature to have label: String instead of children?

0xca551e commented 3 months ago

Hi, I made the change. lmk if it's okay now :+1:

hayleigh-dot-dev commented 3 months ago

Looks great, thanks!