lutaml / express-grammar

ANTLR grammar for EXPRESS (ISO 10303-11)
Other
2 stars 2 forks source link

Problem with EXPRESS schema in STEPmod #2

Open ronaldtse opened 4 years ago

ronaldtse commented 4 years ago

From @zakjan

It seems that the BNF grammar (1994) is missing EXTENSIBLE keyword, ISO 10303-11 PDF spec (2004) is missing MODEL keyword, etc.

Is this known? Which version(s) should be supported by the grammar, the latest PDF, or all?

ronaldtse commented 4 years ago

@zakjan where are you seeing the MODEL keyword? I don't seem to be able to find that in the repo, except in tail remarks...

zakjan commented 4 years ago

In https://github.com/dustintownsend/EXPRESS-Modeling-Language-References/blob/master/iso-10303-11.bnf

zakjan commented 4 years ago

For now, I assume that the PDF spec (2004) is the primary reference.

ronaldtse commented 4 years ago

I can see that these lines have MODEL: https://github.com/dustintownsend/EXPRESS-Modeling-Language-References/blob/6d1dac277edef0ba3504d392fd045243ff5fcd26/iso-10303-11.bnf#L73 https://github.com/dustintownsend/EXPRESS-Modeling-Language-References/blob/6d1dac277edef0ba3504d392fd045243ff5fcd26/iso-10303-11.bnf#L37

@trthurman do we need to support the MODEL keyword? It seems that the Expresso BNF code came with this.

zakjan commented 4 years ago

Also, CONTEXT

TRThurman commented 4 years ago

Expresso supported both part 11 and part 14. MODEL and CONTEXT might be in part 14. So no for part 11, but yes for part 14. part 14 is an extension to part 11 that did not enjoy wide-spread takeup.

On Aug 21, 2020, at 2:57 AM, Ronald Tse notifications@github.com wrote:

I can see that these lines have MODEL: https://github.com/dustintownsend/EXPRESS-Modeling-Language-References/blob/6d1dac277edef0ba3504d392fd045243ff5fcd26/iso-10303-11.bnf#L73 https://github.com/dustintownsend/EXPRESS-Modeling-Language-References/blob/6d1dac277edef0ba3504d392fd045243ff5fcd26/iso-10303-11.bnf#L73 https://github.com/dustintownsend/EXPRESS-Modeling-Language-References/blob/6d1dac277edef0ba3504d392fd045243ff5fcd26/iso-10303-11.bnf#L37 https://github.com/dustintownsend/EXPRESS-Modeling-Language-References/blob/6d1dac277edef0ba3504d392fd045243ff5fcd26/iso-10303-11.bnf#L37 @TRThurman https://github.com/TRThurman do we need to support the MODEL keyword? It seems that the Expresso BNF code came with this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lutaml/expressir/issues/6#issuecomment-678101544, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMMKVC6YN6TCQYNIBP2PHLSBYSFFANCNFSM4QHAAWXA.

Thomas Thurman Principal Electrical Engineer, Rockwell Collins (Retired)

Confidentiality Notice: This e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete/destroy any and all copies of the original message. E-mail transmissions cannot be guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late, incomplete, or contain viruses. Therefore, the recipient should check this email and any attachments for the presence of viruses. The sender accepts no liability for any damage caused by any virus transmitted by this email.

zakjan commented 4 years ago

Another question, in the original Express.g4, there is support for "IFC Named parameters". However, there is no mention about it in the spec. Also, the syntax conflicts with tail remark rule. Should this be kept, or removed?

Express.g4

actualParameterList
    : '(' ('--' SimpleId)? parameter (',' ('--' SimpleId)? parameter)* ')' // IFC Named parameters. Ex: -- Axis1 IfcRepresentationItem() || IfcGeometricRepresentationItem() || IfcDirection([-1., 0.])
    ;

vs spec

167 actual_parameter_list = ’(’ parameter { ’,’ parameter } ’)’ .
TRThurman commented 4 years ago

removed

On Aug 24, 2020, at 8:28 AM, Jan Žák notifications@github.com wrote:

Another question, in the original Express.g4 https://github.com/hypar-io/IFC-gen/blob/IFC4/grammar/Express.g4, there is support for "IFC Named parameters". However, there is no mention about it in the spec. Also, the syntax conflicts with tail remark rule. Should this be kept, or removed?

Express.g4

actualParameterList : '(' ('--' SimpleId)? parameter (',' ('--' SimpleId)? parameter)* ')' // IFC Named parameters. Ex: -- Axis1 IfcRepresentationItem() || IfcGeometricRepresentationItem() || IfcDirection([-1., 0.]) ; vs spec

167 actual_parameter_list = ’(’ parameter { ’,’ parameter } ’)’ . — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lutaml/expressir/issues/6#issuecomment-679126359, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMMKVB33DZXSLL2UMQD6PTSCJTJXANCNFSM4QHAAWXA.

Thomas Thurman Principal Electrical Engineer, Rockwell Collins (Retired)

Confidentiality Notice: This e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete/destroy any and all copies of the original message. E-mail transmissions cannot be guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late, incomplete, or contain viruses. Therefore, the recipient should check this email and any attachments for the presence of viruses. The sender accepts no liability for any damage caused by any virus transmitted by this email.

zakjan commented 4 years ago

Thanks!

ronaldtse commented 4 years ago

MODEL keyword, etc. CONTEXT

I checked 10303-14, the MODEL and CONTEXT keywords are not defined there.