Stability fixes, additional tests and verification

lutaml / expressir

Ruby parser for the ISO EXPRESS language

3 stars 2 forks source link

Stability fixes, additional tests and verification #116

Closed maxirmx closed 2 years ago

maxirmx commented 2 years ago

This PR includes the following enhancements:

finalized fixes for segfaults in C++ native extension in sync with PR placed towards antlr4-native-rb
added native extension sanity checks to CI scripts
added rubocop run to CI scripts, some of ruby files are fixed to meet desired rubocop criteria
added verification of pakaged gems in CI scripts (this is critical since development and release procedures use different toolchains)
cleaned obsolete files

maxirmx commented 2 years ago

UPD
This PR includes the following enhancements:

finalized fixes for segfaults in C++ native extension ( using antlr4-native-rb 2.0.0.1 ) (#74)
added native extension sanity checks to CI scripts (#113)
added rubocop run to CI scripts, some of ruby files are fixed to meet desired rubocop criteria (#113)
added verification of pakaged gems in CI scripts (this is critical since development and release procedures use different toolchains) (#113)
cleaned obsolete files
fixed build for x64-mingw-ucrt binary gem (#103)
generator upgrade to antlr 4.10.1 (#114), in sync with https://github.com/camertron/antlr4-native-rb/pull/13

ronaldtse commented 2 years ago

@maxirmx please feel free to merge when ready, thanks!

maxirmx commented 2 years ago

Great job, a lot of improvements

@maxirmx to be on the same page did antlr4 upgrade lead to any breaking changes? I see a lot of exp files was updated

I'm asking because recently we faced with such situation in lutaml/lutaml#35

ANTLR README says: " Generated 4.10 lexers and parsers are incompatible with code generated by previous versions of ANTLR. You must regenerate all of your code from grammars to use the new runtime."
So I regenerated all C++ files. However, there was no need to touch Ruby expressir code or fix anything in rspec tests. I assume that all C++ changed are hidden by Rice and Ruby wrappers.

ronaldtse commented 2 years ago

Hope it works!

maxirmx commented 2 years ago

I am waiting for https://github.com/camertron/antlr4-native-rb/pull/13 to be accepted so that this code refers to released gem and not to my patch

maxirmx commented 2 years ago

UPD 2 This PR includes the following enhancements:

finalized fixes for segfaults in C++ native extension ( using antlr4-native-rb 2.0.0.1 ) (#74)
added native extension sanity checks to CI scripts (#113)
added rubocop run to CI scripts, some of ruby files are fixed to meet desired rubocop criteria (#113)
added verification of pakaged gems in CI scripts (this is critical since development and release procedures use different toolchains) (#113)
cleaned obsolete files
fixed build for x64-mingw-ucrt binary gem (#103)

The version built with antlr 4.10.1 / antlr4-native-rb 2.1.0 is unstable Upgrade to antlr 4.10.1 has been removed from this PR