search

lutaml / expressir

Ruby parser for the ISO EXPRESS language
3 stars 3 forks source link

Antlr & Rice updated; refactored Token wrapper; added CodeQL workflow #140

Closed maxirmx closed 9 months ago

github-advanced-security[bot] commented 10 months ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

maxirmx commented 9 months ago

This PR introduces updates of rice and antlr4-native gems including fixes suggested by Ribose

I do not think that expressir crashes are elimated. It is just coincidence that the new version is more stable since fixed rice issues did not affect expressir. I believe expressir is affected by two reproducable rice/antlr4-ruby issues that are not fixed (yet)