search

lutaml / expressir

Ruby parser for the ISO EXPRESS language
3 stars 2 forks source link

Refactor code to remove Nokogiri from dependency #40

Closed CAMOBAP closed 3 years ago

CAMOBAP commented 3 years ago

@zakjan @ronaldtse can you confirm?

zakjan commented 3 years ago

It seems it's not used, the dependency might be removed instead?

CAMOBAP commented 3 years ago

@zakjan actually we are using it here https://github.com/lutaml/expressir/blob/master/lib/expressir/express/repository.rb#L78

ronaldtse commented 3 years ago

I think we no longer want to read from the XML, and can have the Nokogiri dependency removed. @zakjan can you help replace the XML work using the new parser nodes? Thanks.

zakjan commented 3 years ago

I might have misunderstood this, but... if XML parser is updated to use the new model, Nokogiri still stays there.

CAMOBAP commented 3 years ago

@zakjan thanks for the response, initially I created the issue because nokogiri was declared as development_dependency, probably we need to "promote" it to runtime_dependency

I think we can close this one

zakjan commented 3 years ago

Moved Nokogiri to runtime dependencies to fix this conflict until XML parser is properly updated or removed.

https://github.com/lutaml/expressir/commit/f0517a226736f93a1ab0649f9cd69d4fa5bbb20c