search

luthraG / image-watermark

A powerful watermark library for single page images, multipage images, and pdf files based on ImageMagick for node.js
https://www.npmjs.com/package/image-watermark
MIT License
102 stars 33 forks source link

Position cannot be changed #2

Closed jtenos closed 9 months ago

jtenos commented 8 years ago

Looks like the default value for position cannot be changed - the code sets it to null, then checks to see if it's empty before setting it to the default of Center.

Would it make sense to allow the caller to define a position? Like:

var position = options.position,

instead of

var position = null,

This may not make sense for some of the alignments, but for a "ltr" alignment, it would be nice to be able to position on one of the corners.

prio101 commented 7 years ago

this issue has been solved in this pull request #10

jtenos commented 9 months ago

Closing since this was solved in a separate pull request