search

lutnos / postfix-vm-pop3d-alpine

Postfix SMTP with vm-pop3d POP3 and stunnel in Alpine Linux Docker
2 stars 0 forks source link

Big thanks and two minor issues #4

Open roguefalcon opened 6 years ago

roguefalcon commented 6 years ago

I'd like to start by saying thanks! This was super helpful. I was up in running very quickly. In the spirit of being helpful in return, there are two minor issues with things in their current state.

The first one is very minor and wouldn't trip up most people but the Start command in the README.md is missing a dash: docker compose up should be docker-compose up

The second issue is the stunnel package has apparently moved from the edge testing repo to the edge community repo and had a few dependency changes that required me to update to Alpine 3.8

Here is my diff on the stunnel Dockerfile.

diff --git a/stunnel/Dockerfile b/stunnel/Dockerfile
index ec3f571..d222ca9 100644
--- a/stunnel/Dockerfile
+++ b/stunnel/Dockerfile
@@ -1,11 +1,11 @@
-FROM alpine:3.4
+FROM alpine:3.8

 MAINTAINER Dave English <dave@lutnos.com>

 RUN apk update && \
     apk add openssl

-RUN echo http://dl-cdn.alpinelinux.org/alpine/edge/testing >> /etc/apk/repositories
+RUN echo http://dl-cdn.alpinelinux.org/alpine/edge/community >> /etc/apk/repositories
 RUN apk update && \
     apk add stunnel

@@ -21,4 +21,4 @@ RUN echo 1.1

Thanks again for putting this on Github. Much appreciated.

lutnos commented 6 years ago

Glad you liked it.

I'm incorporating what you suggest into my 2018 branch, which I will merge soon once I have it live