search

lutraconsulting / MDAL

Mesh Data Abstraction Library
http://www.mdal.xyz/
MIT License
160 stars 50 forks source link

Bed Elevation group always added for .ply file #462

Open jmkerloch opened 1 year ago

jmkerloch commented 1 year ago

There is always a group Bed Elevation added in the PLY Driver :

https://github.com/lutraconsulting/MDAL/blob/deba23b30491c416fb4536c1d5f459d5a44b9225/mdal/frmts/mdal_ply.cpp#L305

I'm doing some tests with MDAL supported files and it seems that it's added for many drivers.

Is there any reason for that ?

PeterPetrik commented 1 year ago

Historically MDAL is/was used for hydro-data where bed elevation is almost always good to have. I am not sure now, but QGIS may have some special treatment of bed elevation dataset for displays.

runette commented 1 year ago

When the PLY driver reads a file - it uses the Z dimension to create a bed elevation data set. It does this - mainly because that is how the other drivers (particularly the TIN driver which was the template for the PLY driver) already worked!

I think this is probably a historic artifact but MDAL does seem to assume that a bed elevation dataset exists - possibly because some of the early hydro data formats are set up that way. It is kind of counter intuitive and it would probably be better not to always have it and to have more conventional X,Y, Z geometry only for the mesh but I am not sure how much work that would be.

On Mon, 29 May 2023 at 10:02, Peter Petrik @.***> wrote:

Historically MDAL is/was used for hydro-data where bed elevation is almost always good to have. I am not sure now, but QGIS may have some special treatment of bed elevation dataset for displays.

— Reply to this email directly, view it on GitHub https://github.com/lutraconsulting/MDAL/issues/462#issuecomment-1566722657, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARC2M5AZJHKOFBZJWY525LXIRJYNANCNFSM6AAAAAAYSOT2JU . You are receiving this because you are subscribed to this thread.Message ID: @.***>