lutraconsulting / ostranslator-ii

A graphical QGIS plugin for loading Ordnance Survey MasterMap into PostGIS.
16 stars 8 forks source link

OS translator II misses out areas #18

Closed gisjeske closed 7 years ago

gisjeske commented 8 years ago

When using the translator on the recent Mastermap Topo data, it misses out some chunks around the boundary (see attached image). The original data is complete so these areas are dropped somewhere in the translator.

missing_areas

mostlyAtNight commented 8 years ago

Hi there,

Does the issue also occur if you import a single tile? if so then I should be able to reproduce the issue here and therefore fix it.

If that's the case, could you send me a smallish .gml.gz file?

Kind regards,

Pete

gisjeske commented 8 years ago

Hi Pete,

Thank you for getting back to me. Yes, the areas that are 'left out' are also not loaded if I load just that one tile. I noticed the tiles that are 'left out' are tiles that are not covering the whole tile area (because they are cut by my areas boundary), maybe that might have something to do with it?

Please find a tile for testing attached.

Many thanks, Jeske 7214215-NT6370-10i43.gz

PeterPetrik commented 7 years ago

ERROR 1: COPY statement failed. ERROR: null value in column "fid" violates not-null constraint DETAIL: Failing row contains (30789, null, 10111, 2, 2004-03-04, {Land}, null, 1932.897216, {1994-05-12,2003-11-26}, {New,Position}, {"Natural Environment"}, {Scrub}, Natural, 50, null, 0103000020346C0000010000003F000000B81E85EBBA411641E17A142E818824...). CONTEXT: COPY topographicarea, line 1: "0103000020346C0000010000003F000000B81E85EBBA411641E17A142E818824418FC2F528D0411641D7A370BD8B882441EC..."

Seems like cropped features are missing fid or it is unreadable by ogr2ogr

PeterPetrik commented 7 years ago

ogr2ogr --config GML_EXPOSE_FID NO fixes the problem by not creating the fid column at all

PeterPetrik commented 7 years ago

fixed, use --ignore-fid for CLI or ignore FID checkbox in GUI