lutraconsulting / ostranslator-ii

A graphical QGIS plugin for loading Ordnance Survey MasterMap into PostGIS.
16 stars 8 forks source link

Comparison of data Translator 2 vs Astun Loader #5

Closed geosmiles closed 9 years ago

geosmiles commented 9 years ago

Attached are two pictures of the same ITN data loaded via the Astun Loader and Translator 2. As you can see Translator has put some of the ITN data down off the Cornish cost.

If you want any more data from my PG, then let me know

Si

astun_loader translator 2

mostlyAtNight commented 9 years ago

Hi Si,

Thanks for the info - that's very useful.

Those features seem to be coming in at 0,0 According to the OS data schema these should be geometry-less features (I believe) but we have actually specified them as point data to work around a problem we had with the underlying ogr2ogr tool.

As a workaround you should be able to simply treat these layers as if they were tabular-only layers (without geometry).

We'll look into a more elegant workaround in upcoming releases.

mixedbredie commented 9 years ago

I can confirm this too - ferrynode, roadnode, roadlinkinformation all have features at 0,0. They are all features with fid/toid like "osgb----------------" and versiondate of 1970-01-01 and, importantly, an ogc_fid of 1. Is this the first feature created or the template or header row?

mostlyAtNight commented 9 years ago

Hi mixedbredie,

Thanks for the additional info - these are indeed a template feature which 'should' have been automatically deleted but it looks like this hasn't occurred - I'll look into it...

mostlyAtNight commented 9 years ago

Hi there,

I've just tried to reproduce the problem using a small sample dataset with no luck.

Can you confirm which version you're using please?

mixedbredie commented 9 years ago

My versions: QGIS 2.6.1 32bit OS translator II plugin v1.0 PostgreSQL 9.3.4 PostGIS 2.1.2 pgRouting 2.0.0 I think the ITN GML is v7 but not sure. It is a recent extract - Jan 2015.

mixedbredie commented 9 years ago

Yeah - GML is v7 xsi:schemaLocation='http://www.ordnancesurvey.co.uk/xml/namespaces/osgb http://www.ordnancesurvey.co.uk/xml/schema/v7/OSDNFFeatures.xsd' fid='GDS-6348787-NONGEO'>