lutris / agora

Public discussion space for the community
11 stars 0 forks source link

Esync toggle complains about incorrect limits even with systemd 240 and ulimits -Hn -> 524288 #14

Open Nocifer opened 5 years ago

Nocifer commented 5 years ago

OS: Arch Linux Lutris version: 0.4.23

As title says. Hard limit is high enough by default due to systemd 240, but when I try to toggle Esync in the settings, Lutris says "Your limits are not set correctly. Please increase them as described here:" etc.

Riesi commented 5 years ago

This is already fixed in master and will ship with 0.5.0. See commit 218c300dc43259199e0e17e97f08cbb8bdb43078

Nocifer commented 5 years ago

Glad to hear that :)

Mar2ck commented 5 years ago

I still have this issue on 0.5.0 Imgur I don't know if this is because my systemd version is below 240. I tried using the old, larger limit and i still get the error Imgur I rebooted my pc both times

robaxelsen commented 5 years ago

I still have this issue on 0.5.0 Imgur I don't know if this is because my systemd version is below 240. I tried using the old, larger limit and i still get the error Imgur I rebooted my pc both times

Same issue here, even with value double the minimum.

rob at code in ~
$ ulimit -Hn
1048576

Edit: On 0.5.2, using Ubuntu MATE 18.04.2.

strycore commented 5 years ago

This issue doesn't have the necessary information to get it resolved. Please complete the bug report.

robaxelsen commented 5 years ago

This issue doesn't have the necessary information to get it resolved. Please complete the bug report.

@strycore thanks for giving us feedback. Wanted to give more bug report information, but not sure what specifically is needed. Could you please clarify what is missing?

Couldn't find any guidelines when pressing "New Issue", except for a link to CONTRIBUTING.md which does not list what is expected in bug reports.

strycore commented 5 years ago

No reproduction steps.

robaxelsen commented 5 years ago

@strycore :pray: thanks

Steps to reproduce:

  1. Install Lutris 0.5.2 on Ubuntu MATE 18.04.2
  2. Install World Of Warcraft via xdg-open open url from Lutris website
  3. Run World of Warcraft successfully upon install
  4. Reboot
  5. Run World of Warcraft again via Lutris, and message appears"Your limits are not set correctly. Please increase them as described here: [...]", even though ulimit -Hn shows it's already esync ready

As for further troubleshooting findings, I noticed that "esync" was set as option in the game settings, but in "Wine version management" I saw no esync packages checked. Checking esync-staging-pba-xxx for install, installing and rebooting.. did not help, however.

Disabling esync in game settings lets me run the game without esync, though.

alindt commented 5 years ago

UPDATE: This problem didn't occur when launching Lutris from terminal, which led me to believe the environment in which Lutris was started from the .desktop shortcut file didn't have the same limits (weird?). Indeed the limits were the default (32k, 64k) and I still had to modify /etc/security/limits.conf and then relogin in order to set the actual limits to 500k.

I have the same problem with Lutris 0.5.2 on Linux Mint 19.1 (64bit) installed from Lutris PPA.

$ ulimit -Hn
524288

$ grep NOFILE /etc/systemd/{user,system}.conf
/etc/systemd/user.conf:DefaultLimitNOFILE=524288
/etc/systemd/system.conf:DefaultLimitNOFILE=524288

$ python3
Python 3.6.7 (default, Oct 22 2018, 11:32:17) 
[GCC 8.2.0] on linux
>>> import resource
>>> resource.getrlimit(resource.RLIMIT_NOFILE)
(524288, 524288)

=====

Steps to reproduce:

  1. Launch Lutris
  2. [Add game] from menu
  3. [Game info] => [Runner] => "Wine"
  4. [Runner options] => [Enable Esync] => "ON"

image

boondoggle commented 5 years ago

Also having this same problem with limits set correctly.

ehashman commented 4 years ago

Can confirm this also affects me on Linux Mint MATE 19 (based on Ubuntu 18.04). Running lutris version 0.5.2.2. ulimit -Hn is 1048576.

I can also confirm that when lutris is launched from a terminal (as opposed to the app menu), I no longer run into the problem.

Riesi commented 4 years ago

Have you tried to do the same as alindt? He had to edit /etc/security/limits.conf to fix his issue when running Lutris from outside the terminal.

https://github.com/lutris/lutris/wiki/How-to:-Esync

Enkouyami commented 4 years ago

Following alindt's steps didn't fix the issue. This issue shouldn't be closed since it isn't resolved.

Also the following labels should be removed: can't reproduce missing information needs confirmation

databoose commented 4 years ago

I seem to have gotten this issue when uninstalling my system wine, which is a problem as i use a self compiled version of wine that otherwise does not work when a wine package is installed.

The limit is fine, it's at 524288 according to the ulimit command, just for some reason lutris doesn't believe it is when i happen to have the wine packages uninstalled (even though otherwise proton/lutris-wine run completely fine without being installed packages)

Maybe there could be an optionable checkbox to ignore software blocks like this in edge cases where the software itself believes something else that isn't true and just prevents you from actually using it.

sebastianulm commented 4 years ago

Same issue. Manjaro (basically arch) Here is a stacktrace. Hope that helps.

Exception ignored in: <function InputDevice.__del__ at 0x7f8160058040>
Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/evdev/device.py", line 159, in __del__
    self.close()
  File "/usr/lib/python3.8/site-packages/evdev/device.py", line 304, in close
    super().close()
  File "/usr/lib/python3.8/site-packages/evdev/eventio_async.py", line 54, in close
    loop = asyncio.get_event_loop()
  File "/usr/lib/python3.8/asyncio/events.py", line 639, in get_event_loop
    raise RuntimeError('There is no current event loop in thread %r.'
RuntimeError: There is no current event loop in thread 'Thread-10'.
Exception ignored in: <function InputDevice.__del__ at 0x7f8160058040>
Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/evdev/device.py", line 159, in __del__
    self.close()
  File "/usr/lib/python3.8/site-packages/evdev/device.py", line 304, in close
    super().close()
  File "/usr/lib/python3.8/site-packages/evdev/eventio_async.py", line 54, in close
    loop = asyncio.get_event_loop()
  File "/usr/lib/python3.8/asyncio/events.py", line 639, in get_event_loop
    raise RuntimeError('There is no current event loop in thread %r.'
RuntimeError: There is no current event loop in thread 'Thread-10'.
alan-cugler commented 3 years ago

Still having this issue in 2021, I have my ulimit set to extreme numbers for other work both as a local user and at the system level. It does seem Lutris isn't picking up the setting or is being limited in a application way some how. I did try running lutris via a terminal with confirmed ulimit set high, and still received the same error.

I will probably try and check on this whole desktop execution thing someone mentioned above but I was hoping terminal execution would suffice as a work around.