lutris:rungame and lutris:rungameid command line args no longer work

[foresto]

Describe the bug

Since upgrading from 0.5.7.1 to 0.5.8, both lutris lutris:rungame/game-slug and lutris lutris:rungameid/game-id are broken. Instead of launching the games, the lutris process just sits there until I kill it. Meanwhile, the same games launch correctly from the lutris GUI.

Steps to reproduce

• lutris lutris:rungame/game-slug

Lutris debugging output (Optional)

$ lutris -d lutris:rungame/fantasy-grounds

2020-12-04 15:52:06,815: lspci is not available. List of graphics cards not available
INFO     2020-12-04 15:52:07,057 [application.do_command_line:319]:Lutris 0.5.8
INFO     2020-12-04 15:52:07,057 [startup.check_driver:73]:Running X.Org Mesa driver 20.0.8 on AMD Radeon (TM) RX 480 Graphics (POLARIS10, DRM 3.35.0, 5.4.0-56-generic, LLVM 10.0.0) (0x67df)
INFO     2020-12-04 15:52:07,057 [startup.check_driver:81]:GPU: 1002:67DF 174B:E347 (amdgpu drivers)

System information (Optional)

Ubuntu 18.04.5 LTS

[foresto]

I found a commit that fixes this in v0.5.8.1, which for some reason still isn't published in the ubuntu PPA. Is there something wrong with that newer version?

[mihawk90]

lutris/lutris#3348 literally 1 second search for "shortcut".

0.5.8.1 is available on the Groovy PPA.

https://launchpad.net/~lutris-team/+archive/ubuntu/lutris?field.series_filter=groovy

[foresto]

lutris/lutris#3348 literally 1 second search for "shortcut".

Don't be a twit. I searched first. Not everyone guesses the magic keyword that finds an existing bug report.

(Also, the PR you linked is completely unrelated. Also, active Ubuntu releases other than Groovy exist. Also, discouraging people from taking the time to report bugs is not a good way to help a project improve.)

[mihawk90]

IDK how I pasted that issue TBH, maybe a weird autocomplete, that's on me. But either way there are multiple issues about this already:

lutris/lutris#3294 lutris/lutris#3281

Also, active Ubuntu releases other than Groovy exist.

I know, I was just pointing out that there is a release in the PPA already. Generally staying with a more current version for gaming is a good idea anyway, but that's outside the scope of this issue.

If you wan't/need this right now you can also clone the git repo to the v0.5.8.1 tag and use the executable there. It is not optimal, but it is an option if you absolutely need it right now:

git clone -b v0.5.8.1 https://github.com/lutris/lutris.git
cd lutris
./bin/lutris lutris:rungame/xyz

Also, discouraging people from taking the time to report bugs is not a good way to help a project improve.

I agree with this, however reviewing and closing the same issues over again is also not a good usage of finite development time.

[strycore]

Also, discouraging people from taking the time to report bugs is not a good way to help a project improve.

Lutris had a open bugtracker. The quality of bug reports kept decreasing. This is not like I didn't give this a chance. At some, it's less helpful to have to sort through trash if trash is the majority of what you get.

[foresto]

At some, it's less helpful to have to sort through trash if trash is the majority of what you get.

Okay, as long as we're all venting, I guess it's my turn.

As a long time developer, I completely understand the weight of open bug trackers. Sorting through the reports is never particularly fun, and duplicate (or vague) ones can sometimes be frustrating. We developers do it anyway, because it helps us improve our work, because we want to share with the community, and because we benefit from the free work that other people donate by investigating and writing up flaws in our code. Believe me, I have been on both sides of it many, many times, and I get it.

However, the extra work is in fact part of being a developer in a community, and blaming me for this general problem is completely unreasonable.

In this case, I did search first, and got no relevant results on "rungame", "uri", "command line", "option", "argument", or any of the other words I tried. None. Not a single one. (I would never have thought to search for "shortcut", since that isn't even a common term for a command line argument; in computing, it's mainly a Windows term.) I also made sure I was using the latest version of lutris from your official PPA, and the bug was (and is) still present there.

In other words, I did the work. Apparently, I did a lot more work than mihawk90 imagined, and probably a lot more than most people do when reporting bugs. I did this because I was trying to save you from duplicate efforts. It didn't help this time; that's occasionally how these things go.

Yet mihawk90 decided to reply to me with a comment that was poorly considered, presumptuous, dismissive, incorrect, and very rude. There's no need for that kind garbage, and there's no need to insult someone with jabs like "literally 1 second search" when you have no idea what efforts they made. Especially someone who has done you the favor of spending their time investigating your broken code and composing a report so that you can easily identify and fix it.

Maybe mihawk90 is having a bad week. Maybe you are, too. (That is, unfortunately, pretty common for a lot of us this year.) I genuinely hope it gets better for both of you guys.

Please, though, don't take it out on me. I'm just trying to help, and I did nothing wrong here.

[strycore]

I wasn't venting or even talking about how this particular issue was handled, which could have been better. For this very project, at this very moment, having a bug tracker with limited access is better for everyone. I've explained this is detail on Patreon: https://www.patreon.com/posts/fortress-mode-44506650

There is no rule stating that Open Source projects should unconditionally accept an unfiltered flow of feedback, this isn't part of the agreement, it isn't part of the core values of Open Source and there are no obligations to adhere to such a model. The "We developers do it anyway" mental model is fine for smaller projects or more balanced teams. I have my own ways of working. I like things in a clean state for me to work on and the lutris bugtracker is my workspace. Since I also do project management tasks of triaging issues and reviewing PRs, this severely impacts on the time available for development on what makes the project move forward. especially when those very features are meant to make it easier for users to report issues. Regardless of all of that, the issue you reported was valid, even if previously fixed, so don't feel like there was any kind of attack of any kind.

[strycore]

oh btw, since I still wanted to give option to have an open discussion space, I created this repository that isn't related to any code.