search

lutris / buildbot

41 stars 27 forks source link

Updated runner for Reicast #101

Open dinoboy197 opened 4 years ago

dinoboy197 commented 4 years ago

A couple of weeks back, I contributed an upgrade to the Reicast runner to fix a number of issues - this upgraded to the most recent stable Reicast release (version r19.07.4).

@RobLoach was nice enough to help me with getting this merged into master and creating a 64bit version of Reicast in the runner repository at https://lutris.net/files/runners/?sdaffads

However, this runner isn't yet available for install in Lutris - installing the Reicast runner from the Lutris UI still installs the old version which is a few years old.

This issue is just for Lutris admins to rebuild the Reicast runner that's in master and make it available to Lutris to install. If there is something else I can do to push this along, please let me know. Thanks!

dinoboy197 commented 4 years ago

I have an inkling as to what the problem might be. I see in the runner install code for the Manage Runners dialog that if there is more than one version of a runner and there is not one marked as default, then the first one is picked:

        elif len(versions) > 1 and system.LINUX_SYSTEM.is_64_bit:
            default_version = [v for v in versions if v["default"] is True]
            if default_version:
                return default_version[0]
        # If we didn't find a proper version yet, return the first available.
        if len(versions_for_arch) >= 1:
            return versions_for_arch[0]

In this case, looking at the output of https://lutris.net/api/runners/reicast, I see the new 64 bit runner, but it's not marked as "default" and it's the second entry, so when Reicast is attempted to be installed, the old version is installed.

So I think the fix would be to mark the new version (v19.07.4) as the default in the response from https://lutris.net/api/runners/reicast.

dinoboy197 commented 4 years ago

Hi @RobLoach! I'm wondering if you happen to know how we could make the runner which you helped to build and upload a couple of months back the default runner?