search

lutris / buildbot

41 stars 27 forks source link

Stop clone function in lib/util.sh from changing directory #35

Closed natis1 closed 6 years ago

natis1 commented 6 years ago

This is seemingly unintentional behavior given there are about 2 build scripts in a total of 79 that expect the clone function to do this.

Still, just to be cautious, and since I don't have my own buildbot I changed 9 scripts total that didn't immediately run

cd ${source_dir}

after git cloning just to be 100% sure this won't break anything but I expect most of these changes are unnecessary, especially on the newer packages.

strycore commented 6 years ago

That's nice, thanks! Just one request to make, put the cd ${source_dir} inside the Build function instead of GetSources, those functions should be viewed as individual tasks (because they can be run as such) so putting a cd command a the end of a function doesn't really fit here.

strycore commented 6 years ago

Awesome, thanks!