lutris / lutris

Lutris desktop client
https://lutris.net
GNU General Public License v3.0
7.82k stars 689 forks source link

Lutris can't open configuration if prelaunch_command contains space (but not always) #1332

Closed monyarm closed 5 years ago

monyarm commented 5 years ago
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/lutris/gui/lutriswindow.py", line 805, in on_edit_game_configuration
    dialog = EditGameConfigDialog(self, game, on_dialog_saved)
  File "/usr/lib/python3.7/site-packages/lutris/gui/config_dialogs.py", line 476, in __init__
    self.build_tabs('game')
  File "/usr/lib/python3.7/site-packages/lutris/gui/config_dialogs.py", line 40, in build_tabs
    self._build_system_tab(config_level)
  File "/usr/lib/python3.7/site-packages/lutris/gui/config_dialogs.py", line 248, in _build_system_tab
    self.system_box = SystemBox(self.lutris_config)
  File "/usr/lib/python3.7/site-packages/lutris/gui/config_boxes.py", line 621, in __init__
    self.generate_widgets('system')
  File "/usr/lib/python3.7/site-packages/lutris/gui/config_boxes.py", line 89, in generate_widgets
    self.call_widget_generator(option, option_key, value, default)
  File "/usr/lib/python3.7/site-packages/lutris/gui/config_boxes.py", line 178, in call_widget_generator
    self.generate_file_chooser(option, value)
  File "/usr/lib/python3.7/site-packages/lutris/gui/config_boxes.py", line 361, in generate_file_chooser
    path = os.path.join(self.game.directory, path)
AttributeError: 'NoneType' object has no attribute 'directory'

The following creates this issue python /home/monyarm/Games/movfs4l.py But /home/monyarm/Games/movfs4l.py UNVFS doesn't

sigmaSd commented 5 years ago

I guess the naming is bad xD prelaunch command is used to point to a script that executes before the game, you're not supposed to write the actual command there

Kustovsky commented 5 years ago

Same problem, can't open config window. It working in su mode Traceback (most recent call last): File "/usr/lib/python3.7/site-packages/lutris/gui/lutriswindow.py", line 805, in on_edit_game_configuration dialog = EditGameConfigDialog(self, game, on_dialog_saved) File "/usr/lib/python3.7/site-packages/lutris/gui/config_dialogs.py", line 476, in __init__ self.build_tabs('game') File "/usr/lib/python3.7/site-packages/lutris/gui/config_dialogs.py", line 40, in build_tabs self._build_system_tab(config_level) File "/usr/lib/python3.7/site-packages/lutris/gui/config_dialogs.py", line 248, in _build_system_tab self.system_box = SystemBox(self.lutris_config) File "/usr/lib/python3.7/site-packages/lutris/gui/config_boxes.py", line 621, in __init__ self.generate_widgets('system') File "/usr/lib/python3.7/site-packages/lutris/gui/config_boxes.py", line 89, in generate_widgets self.call_widget_generator(option, option_key, value, default) File "/usr/lib/python3.7/site-packages/lutris/gui/config_boxes.py", line 178, in call_widget_generator self.generate_file_chooser(option, value) File "/usr/lib/python3.7/site-packages/lutris/gui/config_boxes.py", line 361, in generate_file_chooser path = os.path.join(self.game.directory, path) AttributeError: 'NoneType' object has no attribute 'directory'

Kustovsky commented 5 years ago

Downgrading to v0.4.21.1 solved this problem. (At least i can use lutris until 0.5)

strycore commented 5 years ago

I wasn't able to reproduce the issue in next

erkexzcx commented 5 years ago

I am using the latest version in community repositories on Arch Linux. Yep - I am unable to start Lutris now. Anyone dare to share a workaround on starting Lutris settings?

Found it myself:

$ vim "$HOME/.config/lutris/system.yml"

And delete whole lines containing your commands with spaces.

monyarm commented 5 years ago

You have to edit the file where lutris saves its configs, and remove the offending setting

On Sun, 23 Dec 2018, 17:32 Erikas <notifications@github.com wrote:

I am using the latest version in community repositories on Arch Linux. Yep

  • I am unable to start Lutris now.

Anyone dare to share a workaround on starting Lutris settings?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lutris/lutris/issues/1332#issuecomment-449643903, or mute the thread https://github.com/notifications/unsubscribe-auth/AC50qp7r9-Bl_qtAPyr0G2P6zx9H55L7ks5u76IKgaJpZM4YYpvY .