lutris / lutris

Lutris desktop client
https://lutris.net
GNU General Public License v3.0
7.89k stars 690 forks source link

Add a DuckStation Runner (Also sync Duckstation Library) #3707

Open monyarm opened 3 years ago

monyarm commented 3 years ago

Duckstation is a PS1 Emulator, it's relatively new, but is one of the best currently available. Duckstation also functions like Dolphin, in that it has a library with all the games listed.

While I will give creating a json runner a go, and will create a pull request if I create one. I figure I should at least mention Duckstation.

EduardTheFirst commented 3 years ago

Duckstation is a PS1 Emulator, it's relatively new, but is one of the best currently available. Duckstation also functions like Dolphin, in that it has a library with all the games listed.

While I will give creating a json runner a go, and will create a pull request if I create one. I figure I should at least mention Duckstation.

hey i have created this already by downloading it from the runner menu but i deleted the pull request because i could not manage to pass the syntax error that i had of flake8

but the duckstation worked

if i can help you in anyway i would love to do so

monyarm commented 3 years ago

You mean you had made a pull request with a duckstation runner? Or am I misunderstanding, cause there wasn't a duckstation runner when I checked.

On Wed, Sep 29, 2021, 12:00 AM EduardTheFirst @.***> wrote:

Duckstation is a PS1 Emulator, it's relatively new, but is one of the best currently available. Duckstation also functions like Dolphin, in that it has a library with all the games listed.

While I will give creating a json runner a go, and will create a pull request if I create one. I figure I should at least mention Duckstation.

hey i have created this already by downloading it from the runner menu but i deleted the pull request because i could not manage to pass the syntax error that i had of flake8

but the duckstation worked

if i can help you in anyway i would love to do so

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lutris/lutris/issues/3707#issuecomment-929621419, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXHJKWTE7ZXDQUA3Y625JTUEIUINANCNFSM5E57YRHQ .

telanus commented 3 years ago

@monyarm like @EduardTheFirst said, they created a runner: https://github.com/lutris/lutris/pull/3698. But they removed it.

Also Duckstation is available in Libretro.

monyarm commented 3 years ago

@monyarm like @EduardTheFirst said, they created a runner: https://github.com/lutris/lutris/pull/3698. But they removed it.

Also Duckstation is available in Libretro.

I'll check the runner, maybe add it as a patch or something. As for Libretro. I prefer using the standalone emulators when available.

EduardTheFirst commented 3 years ago

You mean you had made a pull request with a duckstation runner? Or am I misunderstanding, cause there wasn't a duckstation runner when I checked. On Wed, Sep 29, 2021, 12:00 AM EduardTheFirst @.***> wrote: Duckstation is a PS1 Emulator, it's relatively new, but is one of the best currently available. Duckstation also functions like Dolphin, in that it has a library with all the games listed. While I will give creating a json runner a go, and will create a pull request if I create one. I figure I should at least mention Duckstation. hey i have created this already by downloading it from the runner menu but i deleted the pull request because i could not manage to pass the syntax error that i had of flake8 but the duckstation worked if i can help you in anyway i would love to do so — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3707 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXHJKWTE7ZXDQUA3Y625JTUEIUINANCNFSM5E57YRHQ .

i mean i created a pull request but it failed with flake8 i tried to fix it several times no one replyed me on this so i deleted the pull request but maybe i still have the files anyway it was downloading the appdata file and launching it once. then you need to manually select the new appdata file excecutable location in lutris and voila its working i love duckstation more that all other psx emulators out there mednaffen good also because of the netplay.

so i changed the downloading method for not unpacking the file if its appdata file. then to excecute the duckstation download then you need to add the new excecutable in lutris for duckstation where the appdata is stored

i can rebuild the code or look for the files if you want to fix the flake8 syntax or if you have another suggestion i would like to hear it

telanus commented 3 years ago

@EduardTheFirst you could look at yourpull request, all the files are still there.

EduardTheFirst commented 3 years ago

@EduardTheFirst you could look at yourpull request, all the files are still there.

no i have deleted it. anyway i can write it again its really simple i just need like 2 hours or something

monyarm commented 3 years ago

You do know that deleting the files in a commit in the pull request doesn't get rid of them right? You can just grab the files from the commit before you started deleting.

On Wed, Sep 29, 2021, 7:35 PM EduardTheFirst @.***> wrote:

@EduardTheFirst https://github.com/EduardTheFirst you could look at yourpull request, all the files are still there.

no i have deleted it. anyway i can write it again its really simple i just need like 2 hours or something

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lutris/lutris/issues/3707#issuecomment-930342435, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXHJKXUXH3QTZMM2ST4YMDUEM54XANCNFSM5E57YRHQ .

EduardTheFirst commented 3 years ago

You do know that deleting the files in a commit in the pull request doesn't get rid of them right? You can just grab the files from the commit before you started deleting. On Wed, Sep 29, 2021, 7:35 PM EduardTheFirst @.***> wrote: @EduardTheFirst https://github.com/EduardTheFirst you could look at yourpull request, all the files are still there. no i have deleted it. anyway i can write it again its really simple i just need like 2 hours or something — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3707 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXHJKXUXH3QTZMM2ST4YMDUEM54XANCNFSM5E57YRHQ .

i am new to git https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-branches-in-your-repository/deleting-and-restoring-branches-in-a-pull-request tried it and i could not find my git pull

EduardTheFirst commented 3 years ago

@EduardTheFirst you could look at yourpull request, all the files are still there.

found it https://github.com/lutris/lutris/pull/3698/ tell me if its good for you

you need the

init file duckstation file and runner file

https://github.com/EduardTheFirst/lutris/blob/e198b5bf664d76604c729de15e204c7467eca7e5/lutris/runners/duckstation.py https://github.com/EduardTheFirst/lutris/blob/eab413013a2bfd27e4d6faef12a384d9ab7454d4/lutris/runners/runner.py

you can download the files and create own lutris build with duckstation but please fix the flake8 its complaining for nothing

EduardTheFirst commented 3 years ago

please update me if you stuck on something lets try to solve it together

p.s. Found a thing maybe my build is older idk but the duckstation file will get downloaded either to the cache folder or to local runners ".cache/lutris/duckstation-qt-x64.AppImage"

after the first run of duckstation in lutris you excecute and its asking to change the folder to /home/$USERNAME/applications where all the appdata files are stored so before you close lutris change the excecutable to this exact folder in lutris

EduardTheFirst commented 3 years ago

any update from anyone ? have you tried it ?

Duckstation is a PS1 Emulator, it's relatively new, but is one of the best currently available. Duckstation also functions like Dolphin, in that it has a library with all the games listed.

While I will give creating a json runner a go, and will create a pull request if I create one. I figure I should at least mention Duckstation.

EduardTheFirst commented 3 years ago

https://github.com/lutris/lutris/pull/3710

added this pull request