search

lutris / website

Lutris.net website
https://lutris.net
GNU Affero General Public License v3.0
124 stars 110 forks source link

Origin and Ubisoft Icons are not included in the Runtime #666

Closed danieljohnson2 closed 1 year ago

danieljohnson2 commented 1 year ago

When you download a new Lutris runtime, the Origin and Ubisoft icons are absent.

However, the even newer itch.io icon is.

The files seem to be downloadable: https://raw.githubusercontent.com/lutris/lutris-runtime/master/icons/hicolor/scalable/apps/origin.svg https://raw.githubusercontent.com/lutris/lutris-runtime/master/icons/hicolor/scalable/apps/ubisoft.svg

But they aren't listed in the JSON response from the Lutris.net api; I could hack a fix for this in the client, but that seems... not the intended way. I think they need to be in the Lutris.net database.

strycore commented 1 year ago

Icons not only need to be present on a server but they also need to be listed in the runtime API. In that case the "icons" runtime: https://lutris.net/admin/runners/runtime/14/change/

I may have removed the Ubisoft and Origin icons by mistake when cleaning up the mess I made with dobharchu (https://github.com/lutris/dobharchu) a while ago.

strycore commented 1 year ago

I added the runtime components back