search

lutris / wine

Repository containing source code for various Lutris Wine builds
Other
142 stars 23 forks source link

Why has fsync been disabled? #83

Closed Atemu closed 3 years ago

Atemu commented 3 years ago

6.1 release notes say:

Fsync is removed (due to issues in

...?

Fsync works just fine on my machine with 5.7.

liberodark commented 3 years ago

In 6.10 i think is not disable have no see information about that.

SveSop commented 3 years ago

Cant see any mention of using fsync patches https://github.com/lutris/wine/blob/lutris-6.10-2/wine-tkg-config.txt , nor any fsync.h in https://github.com/lutris/wine/tree/lutris-6.10-2/dlls/ntdll/unix

Maybe disabled due to issues, and forgot enable it again? :) No issues with fsync or futex2 on TKG or other custom wine versions that i know of, so i am not sure.

liberodark commented 3 years ago

Same on my side have no issue with fsync probably need to wait for re enable on lutris.

tannisroot commented 3 years ago

The patch seems to cause issues in Guild Wars 2 for some users even when fsync is disabled. Given that Fsync requires a custom kernel which not many are going to install / compile, i decided to remove it for now, since the users who have the knowledge base to install a new kernel and actually use it should be able to use wine-tkg to compile wine with fsync enabled.

Atemu commented 3 years ago

The GW2 issue (which I was also hit by; it's my main game on Linux) was an upstream bug that should have been fixed in 6.5 AFAIK.

Given that Fsync requires a custom kernel which not many are going to install / compile

You'd be surprised how many people use fsync capable kernels. Arch has the zen-kernel in their core repos, there's lqx for all the Debianish distros and I've added both to Nixpkgs/NixOS.

Also, since this only affected one game's launcher, a -gw2 version similar to the -lol releases etc. might have been more appropriate.

i decided to remove it for now, since the users who have the knowledge base to install a new kernel and actually use it should be able to use wine-tkg to compile wine with fsync enabled.

Able to, yes. But installing a custom kernel (especially when binary caches are available; in NixOS it's a one-line change) is a lot easier than cooking up a custom WINE and getting Lutris to use that.

The official Lutris binaries are simply more convenient.

tannisroot commented 3 years ago

Ok, I will re-enable it then.

Atemu commented 3 years ago

6.10-3 works perfectly with GW2, thank you!

Not sure whether it's futex2 or all the improvements done to WINE in the mean time, but GW2 was running the smoothest it ever has today.