luttje / glua-api-snippets

Scrapes the Garry's Mod Wiki in order to build Lua Language Server comments that will provide IDE suggestions and autocompletion.
MIT License
15 stars 5 forks source link

Need some fixes #13

Closed AMD-NICK closed 6 months ago

AMD-NICK commented 11 months ago

timer.Adjust

screenshot_2023-07-20_06 00 43@2x

all parameters are optional

GAMEMODE.FolderName screenshot_2023-07-20_06 03 13@2x https://wiki.facepunch.com/gmod/~search:FolderName

luttje commented 11 months ago

Hi @AMD-NICK, thanks for reporting this!

The first problem (timer.Adjust) needs to be fixed on the wiki itself. The optional args need a default provided. Like with this function (go to edit on the wiki to see the syntax): https://wiki.facepunch.com/gmod/cam.PushModelMatrix

The second is indeed something the scraper currently does not pick up on. I may look into this in a couple months or I'll accept a PR that implements a fix as well.

Vurv78 commented 10 months ago

I've edited the wiki entry for timer.Adjust to have defaults set for the last two arguments

https://wiki.facepunch.com/gmod/timer.Adjust~diff:551428

luttje commented 6 months ago

@all-contributors please add @AMD-NICK for bug

allcontributors[bot] commented 6 months ago

@luttje

I've put up a pull request to add @AMD-NICK! :tada: