Implement new data structures from the wiki

luttje / glua-api-snippets

Scrapes the Garry's Mod Wiki in order to build Lua Language Server comments that will provide IDE suggestions and autocompletion.

MIT License

18 stars 6 forks source link

Implement new data structures from the wiki #51

Closed robotboy655 closed 6 months ago

robotboy655 commented 6 months ago

This PR does the following:

Implement function overloads from wiki
Implement altType for function arguments
Implement wiki's function callback definitions
Print errors when scraping fails - Maybe it should exit as well?

It partially addresses issues in https://github.com/luttje/glua-api-snippets/issues/47 and reduces reliance on hardcoded overrides.

We do lose some nuance with callback types, such as string[] being replaced with table in concommand.Add autocomplete callback, but I think we can live with that.

luttje commented 6 months ago

Heya @robotboy655 , thanks again for your work.

I see a test is failing. If it's only two or so tests, I'm fine with you commenting them for now, instead of writing new ones. I will work on writing some better tests for your code another time.

Let me know if you think this is good to merge and I'll get on it

robotboy655 commented 6 months ago

@luttje I have fixed the tests.

I have tested the resulting output from my PR against a the previous version, and here's the result:

Basically only the documentation that was overwritten in custom/ has changed, so yeah, I think this is safe to merge.