Fix Alliance system (inviting is broken)

[luttje]

The alliance system is only half tested and requires more features

• [x] Implement changing member ranks through the UI
• [ ] Test rank changing
• [x] Implement kicking through UI
• [ ] Test kicking through UI
• [x] Implement + test leaving
• [x] Implement + test creation
• [ ] Optimize where possible. Currently a lot of queries are performed, that may be better to keep in memory? I'm not sure if this is prudent, should benchmark if it really matters.
• [ ] Fix invite bug:

  • Alliance accept invite doesn't show to invited person.

    • When I forced the invite to accept, the inviter saw that the invited joined (their alliance panel updated), but they didn't actually join. (:GetCharacter():GetData("alliance") was nil)

    • Note that I incorrectly forced the invite to accept, I caused this error which I only just noticed. So I guess the point before this is invalid. Error:

  L05/10/2024 - 14:39:07: Lua Error: gamemodes/helix/gamemode/core/libs/thirdparty/sv_mysql.lua:552: [mysql] MySQL Callback Error!
  gamemodes/experiment-redux/schema/meta/sv_player.lua:22: Alliance must be a table with an `id` and `name` property.
  
  stack traceback:
    [C]: at 0xe23560e0
    [C]: in function 'error'
    gamemodes/helix/gamemode/core/libs/thirdparty/sv_mysql.lua:552: in function <gamemodes/helix/gamemode/core/libs/thirdparty/sv_mysql.lua:547>
    [C]: in function 'v'
    lua/includes/modules/hook.lua:96: in function <lua/includes/modules/hook.lua:79>

[luttje]

/AllyInvite

[ERROR] gamemodes/experiment-redux/schema/meta/sh_player.lua:42: attempt to compare number with nil

GetAllianceCanManageRoster - gamemodes/experiment-redux/schema/meta/sh_player.lua:42
RequestInviteMember - gamemodes/experiment-redux/schema/libs/sv_alliance.lua:536
OnRun - gamemodes/experiment-redux/schema/sh_commands.lua:55
Run - gamemodes/helix/gamemode/core/libs/sh_command.lua:499
Parse - gamemodes/helix/gamemode/core/libs/sh_command.lua:561
Run - gamemodes/helix/gamemode/core/hooks/sv_hooks.lua:324
func - gamemodes/helix/plugins/chatbox/sh_plugin.lua:154
unknown - lua/includes/extensions/net.lua:38

[luttje]

https://github.com/luttje/gmod-experiment-redux/assets/2738114/bc4ddb1d-147e-4886-a42c-343397314f03

[luttje]

• Alliance accept invite doesn't show to invited person.
• When I forced the invite to accept, the inviter saw that the invited joined (their alliance panel updated), but they didn't actually join. (:GetCharacter():GetData("alliance") was nil)
• Note that I incorrectly forced the invite to accept, I caused this error which I only just noticed. So I guess the point before this is invalid. Error:

  
  L05/10/2024 - 14:39:07: Lua Error: gamemodes/helix/gamemode/core/libs/thirdparty/sv_mysql.lua:552: [mysql] MySQL Callback Error!
  gamemodes/experiment-redux/schema/meta/sv_player.lua:22: Alliance must be a table with an `id` and `name` property.

stack traceback: [C]: at 0xe23560e0 [C]: in function 'error' gamemodes/helix/gamemode/core/libs/thirdparty/sv_mysql.lua:552: in function <gamemodes/helix/gamemode/core/libs/thirdparty/sv_mysql.lua:547> [C]: in function 'v' lua/includes/modules/hook.lua:96: in function <lua/includes/modules/hook.lua:79>