search

luttje / gmod-ghost-replay

Record and replay your movements in Garry's Mod.
MIT License
0 stars 1 forks source link

Addon for this mod. #1

Closed jibraeelabdel closed 10 months ago

jibraeelabdel commented 10 months ago

Hello, I hope this finds you well. I have branched off your original code to create a new feature to change the camera angle/view of your recorded gameplay. However, I do not have permission to raise the PR for this new feature.

This new code would allow users to access the camera while recording and switch to new view such as: -Free Camera -Death Camera -Freeze Camera -Fixed Camera

I also added a new GUI Combo Box for swapping between the different views.

In the future, I hope to add more features to this software such as hiding the UI, character animations and other features. Would I be able to get access to raise the new pull request?

Thank you, Jib

luttje commented 10 months ago

Hi there! Thanks for your kind message and your willingness to contribute.

Although I don't actively play Garry's Mod anymore, I much appreciate any new features for this repo, so it may in turn help others!

I assume you cloned this repository and are now unable to push any changes. I could make you a contributor, but I'd much rather adhere to the GitHub flow. You may already know what I'm about to describe, but just in case:

You should be able to make a Pull Request if you Fork this repository, you can find out more about how to do that here. After forking and making the changes, you commit them to your own fork. At that point you'll be able to make a Pull Request.

To make it easier I suggest you do the following:

  1. Make a fork of this repository
  2. Clone your fork to your computer
  3. Create a branch (this makes it easier to make different Pull Requests in the future), for example name the new branch: feature/camera-enhancements
  4. Copy all the files that you changed (in the clone) over the fork (do not copy the hidden .git folder)
  5. Commit those changes to your fork and push them to GitHub
  6. If you then go here: https://github.com/luttje/gmod-ghost-replay/pulls GitHub will see that you have a fork with changes. It will then ask you if you want to make a PR for your changes.

This way we adhere to the GitHub flow and anytime you make changes to your fork, you can create a PR here to merge them in.

I'll gladly merge any contributions into this project this way.

Thanks again for contributing, let me know if you need any help.

jibraeelabdel commented 10 months ago

@luttje Thanks for responding. I am glad you are happy to maintain this codebase and adhere to proper git flow. I have amended the issue and have raised the new pull request for you to review. Thank you so much for creating this tool, just recently, I wanted to look around for a GMOD solution that offered a replay similar to Rockstar Editor or Minecraft Replay mod. Looking on Reddit, it looks like there is a thread of users who have been requesting a tool like this for years. I am glad to be able to contribute to this project and help others with their need for this software. Thank you!

luttje commented 10 months ago

So glad to hear this helps you and again: thanks for helping with your great PR.

It's merged and I welcome any other changes if you ever have them.

Have a good one! 😊

jibraeelabdel commented 10 months ago

Can I also ask what resources you used for learning and programming? I am an experienced programmer but I am new to Gmod and its natives. Do you have any references? The current documentation is sorta lacking

luttje commented 10 months ago

For Garry's Mod my main resource was (and when I dive back in, still is):

I didn't really use tutorials for learning Garry's Mod Lua. There weren't many back then. I mostly looked at things I liked in existing open-source gamemodes and addons.