search

lutzky / ttime3

Timetable generator for the Technion IIT
http://lutzky.net/ttime3
GNU General Public License v3.0
6 stars 2 forks source link

Workshops are not showing #233

Open gilshahar7 opened 2 years ago

gilshahar7 commented 2 years ago

I am taking a course with an optional weekly workshop (סדנה) and it wont display them in any of the schedules.

Course number: 044252

The workshops are showing normally in CheeseFork so it might just be a simple addition of this data.

lutzky commented 2 years ago

Are you sure about that course number? 044252 is מערכות ספרתיות ומבנה המחשב, and as far as I can tell it shows up correctly. Looking at the raw cheesefork data (give it a moment to load), I see the following courses with the word סדנה in their name: 014880, 016829 (has an empty schedule), 205430, 205430, 206013, 216112, 234901 - and they all seem to be represented correctly in ttime (nor is there anything unusual about the data for them). Can you double-check the course number?

gilshahar7 commented 2 years ago

Yes, here is how i see it in the GUI version of CheeseFork:

image

gilshahar7 commented 2 years ago

And yeah it is not showing up the the CheeseFork database, maybe it is displaying those from a different database?

lutzky commented 2 years ago

Oh heavens, I just noticed that it shows up in the course notes:

סדנאות רשות, לבחירתכם אחת מהר"מ: ימי א, 12.30-14.30 ימי ב, 10.30-12.30 ימי ב, 15.30-17.30 ימי ג, 10.30-12.30 ימי ד, 14.30-16.30 ימי ה, 08.30-10.30 ימי ה, 10.30-12.30 ימי ה, 12.30-14.30

...is it possible that cheesefork actually parses those? I wonder if the format is consistent between various courses...

gilshahar7 commented 2 years ago

I doubt it, mabye its best to contact Michael

lutzky commented 2 years ago

Well I'll be damned, it does: https://github.com/michael-maltsev/cheese-fork/blob/5a949d825fb20f14a04c770edad7cd0c7265e455/deploy/course-manager.js#L59-L113

I love the special-casing of building names in particular: https://github.com/michael-maltsev/cheese-fork/blob/5a949d825fb20f14a04c770edad7cd0c7265e455/deploy/course-manager.js#L85-L93

gilshahar7 commented 2 years ago

Yup, i just found this too: https://github.com/michael-maltsev/cheese-fork/issues/21#issuecomment-714542033

lutzky commented 2 years ago

Workaround until this is implemented: Use Custom Events (under Settings)

lutzky commented 2 years ago

Alright, after discussion at https://github.com/michael-maltsev/cheese-fork/issues/27, I don't think we're interested in building a shared solution for this. I'm open to pull requests implementing this for ttime, but I don't think I'll get to doing it myself.