search

luukhaijes / kinde-angular

Angular wrapper around the Kinde Typescript SDK
MIT License
14 stars 5 forks source link

Update to angular 18? #17

Open jonschmidt opened 2 months ago

jonschmidt commented 2 months ago

Is your feature request related to a problem? Please describe. Can we update this library to angular 18? It has been out for 2 months now, and I would love to start building with this library, but we cannot until it is updated

Describe the solution you'd like Update to angular 18

JoshuaNitschke commented 2 months ago

I am using it with an angular 18 app, no issues yet. I switched from angular-auth-oidc-client and custom auth guard to this wrapper with the built in auth guard. Works great.

jonschmidt commented 2 months ago

Ah, good to know. Are you using --force or --legacy-peer-deps?

I could not get past a typescript error in the libraries angular dependency, but I will keep trying

JoshuaNitschke commented 2 months ago

Confirming I do have my .npmrc currently set to

legacy-peer-deps=true

(But I think I did that for a different dependency, not kinde, but I can't remember)

luukhaijes commented 2 months ago

Thanks for creating this issue, if you're able to provide a PR for this it would be great. Currently I'm unable to do so, just bought a house and started rebuilding it. If you're unable to provide PR I can try to work on it in between.

luukhaijes commented 1 month ago

I'm back, I can have a look at it this week±

luukhaijes commented 3 weeks ago

Hi, sorry for the late response. Still working on my house renovations, found some time to work on this. Hope to have a PR ready by tomorrow.

luukhaijes commented 2 weeks ago

I have a PR, sorry for the delay.