upcoming sf break sfnetworks when using s2

[edzer]

Hi Luuk! Please see https://github.com/r-spatial/sf/issues/1649 and consider commenting there in case solving the issue is not trivial - the only thing I see in the revdep check is:

* checking tests ... ERROR
  Running ‘testthat.R’
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
    1. └─sf::st_nearest_feature(rdm, net) test_join.R:37:0
    2.   └─s2::s2_closest_feature(x, y)
    3.     ├─s2:::cpp_s2_closest_feature(as_s2_geography(x), as_s2_geography(y))
    4.     ├─s2::as_s2_geography(y)
    5.     └─s2:::as_s2_geography.default(y)
    6.       ├─s2::as_s2_geography(wk::as_wkb(x))
    7.       ├─wk::as_wkb(x)
    8.       └─wk:::as_wkb.default(x)
    9.         ├─wk::wk_translate(x, new_wk_wkb(crs = wk_crs_inherit()), ...)
   10.         └─wk:::wk_translate.default(...)
   11.           └─wk::wk_handle(handleable, wk_writer(to), ...)

  [ FAIL 1 | WARN 0 | SKIP 0 | PASS 235 ]

which is not very helpful.

[luukvdmeer]

Hi @edzer, for sfnetworks there should be no reverse dependency issues anymore. Thanks @loreabad6 for looking at this. We submitted to CRAN today.

[edzer]

Great, thanks @luukvdmeer & @loreabad6 !