search

luukvdmeer / sfnetworks

Tidy Geospatial Networks in R
https://luukvdmeer.github.io/sfnetworks/
Other
347 stars 20 forks source link

Licence #15

Closed eracle closed 4 years ago

eracle commented 4 years ago

Hello there! First of all, thanks for this library. I was wondering, what's its licence? Regards

Robinlovelace commented 4 years ago

TBC.

luukvdmeer commented 4 years ago

The current version of sfnetworks (which is the master branch of this repository) has a GPL-2 license. However, we are developing a new version of sfnetworks in a separate branch. This branch contains a license file: https://github.com/luukvdmeer/sfnetworks/blob/develop/LICENSE

Robinlovelace commented 4 years ago

This raises a wider question: should issues be closed when fixed in the develop or master branch? Given that most people will download the project from the master branch by default, I suggest we start the convention of only closing issues when they are fixed on master, encouraging frequent dev -> master PRs.

Sound reasonable @luukvdmeer ? I see a danger of the master branch stagnating if we're overly reticent.

luukvdmeer commented 4 years ago

@Robinlovelace yes, that sounds reasonable indeed! Let's do that.

(although for this specific question it is answered also for the current master branch by pointing to the GPL-2 license that is stated in the DESCRIPTION file, plus mentioning that in the next release the license will change?)

Robinlovelace commented 4 years ago

Great, yes the issue seems fixed, good to have that protocol, only close issues when closed on master. FYI we discussed this at length in the PCT issue tracker, e.g.: https://github.com/npct/pct-shiny/issues

Makes sense to only close things when they are 'deployed'. Github does this automagically when you send a commit e.g. titled

Add license, close #15

It will only close the issue when merged to master.