search

luukvdmeer / sfnetworks

Tidy Geospatial Networks in R
https://luukvdmeer.github.io/sfnetworks/
Other
338 stars 20 forks source link

Comply with S2 changes #150

Closed loreabad6 closed 3 years ago

loreabad6 commented 3 years ago

Fix #147. I have s2 to suggests along with a dynamically registered method for as_s2_geography() which will hopefully allow for lat/long operations to work properly with the new S2 changes. The code works both when sf::sf_use_s2(TRUE) and sf::sf_use_s2(FALSE)

codecov-commenter commented 3 years ago

Codecov Report

Merging #150 (dee3e08) into master (5752fd4) will decrease coverage by 0.06%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
- Coverage   85.90%   85.84%   -0.07%     
==========================================
  Files          20       21       +1     
  Lines        1348     1349       +1     
==========================================
  Hits         1158     1158              
- Misses        190      191       +1
Impacted Files Coverage Δ
R/s2.R 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5752fd4...dee3e08. Read the comment docs.