search

luukvdmeer / sfnetworks

Tidy Geospatial Networks in R
https://luukvdmeer.github.io/sfnetworks/
Other
338 stars 20 forks source link

Develop #170

Closed agila5 closed 2 years ago

codecov-commenter commented 3 years ago

Codecov Report

Merging #170 (1056e4a) into master (70a5136) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #170   +/-   ##
=======================================
  Coverage   85.93%   85.93%           
=======================================
  Files          21       21           
  Lines        1351     1351           
=======================================
  Hits         1161     1161           
  Misses        190      190
Impacted Files Coverage Δ
R/sfnetwork.R 86.55% <100.00%> (ø)
R/spatstat.R 48.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 70a5136...1056e4a. Read the comment docs.

agila5 commented 2 years ago

I think there is enough material for the 0.5.3 minor release (and I can't focus on any big new feature at the moment). Feel free to review it whenever you can.

luukvdmeer commented 2 years ago

Hi @agila5 thanks for your work on this and sorry I could not look into it earlier. It looks great! I updated the changelog and also added the extra example of #159 . I wait now until check have passed and will then merge + release.

agila5 commented 2 years ago

Hi @agila5 thanks for your work on this and sorry I could not look into it earlier.

No worries!

I wait now until check have passed and will then merge + release.

🎉 🎉 🎉

btw: maybe you need to rename the vignettes in _pkgdown.yml after merging