search

luukvdmeer / sfnetworks

Tidy Geospatial Networks in R
https://luukvdmeer.github.io/sfnetworks/
Other
338 stars 20 forks source link

Reassign CRS to `roxel` in tests to comply with different GDAL and PROJ versions #189

Closed loreabad6 closed 2 years ago

loreabad6 commented 2 years ago

I am hoping this will avoid errors on the CRAN checks. I am trying to check on rhub, will report if this succeeds.

codecov-commenter commented 2 years ago

Codecov Report

Merging #189 (a83322d) into master (07906d8) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #189   +/-   ##
=======================================
  Coverage   72.16%   72.16%           
=======================================
  Files          21       21           
  Lines        1351     1351           
=======================================
  Hits          975      975           
  Misses        376      376
Impacted Files Coverage Δ
R/plot.R 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 07906d8...a83322d. Read the comment docs.

loreabad6 commented 2 years ago

Previous checks on Solaris failed. Will try with this solution and report back once Rhub is done checking.

loreabad6 commented 2 years ago

Seems to pass on Solaris. Will check once more with rhub::check_for_cran()

loreabad6 commented 2 years ago

So I think it should be ready now.

loreabad6 commented 2 years ago

Closing this pull request since it should be addressed now by #193