Open agila5 opened 1 year ago
Hi @agila5, thanks for noticing this! Are you planning to work on this? Otherwise I will start checking the function refactoring since I am also fixing #256 which could then be in a single PR
Hi @loreabad6! Unfortunately, I'm really busy for the next 2 weeks (approximately) so feel free to work on this issue if you can, otherwise I will explore the pillar docs sometime in October.
Describe the bug According to the official documentation, starting from
tibble
v3.1.0 (the current CRAN version is 3.2.1) the functiontrunc_mat
is deprecated since "printing is handled entirely by the pillar package". This is a slight problem for us since we usetrunc_mat
inprint.sfnetwork
:https://github.com/luukvdmeer/sfnetworks/blob/23a4125030178f5c42ebb48d2547052a31a3cdea/R/sfnetwork.R#L430-L431
Moreover, starting from tibble 3.1.8, the output of
trunc_mat
slightly changed and the printing ofsfnetwork
objects is much less informative (see below).Reproducible example Current output:
Created on 2023-08-02 with reprex v2.0.2
Old output:
Expected behavior I think the old behaviour is a bit better. Happy to check the pillar docs to see how we can define an ad-hoc printing method.
R Session Info NA