search

luukvdmeer / sfnetworks

Tidy Geospatial Networks in R
https://luukvdmeer.github.io/sfnetworks/
Other
347 stars 20 forks source link

Explicitizing edges does not correctly handle loop edges #82

Closed luukvdmeer closed 3 years ago

luukvdmeer commented 3 years ago

Describe the bug When explicitizing spatially implicit edges, a line is drawn between source and target node of each edge. However, when the source and target node are the same, it creates a linestring containing a single point, while internally we would expect a linestring with a start and endpoint (which happen to have the same coordinates). Note that neither of those linestrings are actually valid geometries according to the simple feature standard, but that is what happens with loop edges either way.

luukvdmeer commented 3 years ago

Fixed on develop, will be pushed to master soon, along with the new version