search

luvit / lit

Toolkit for developing, sharing, and running luvit/lua programs and libraries.
http://lit.luvit.io/
Apache License 2.0
245 stars 58 forks source link

Error while running `lit make lit://luvit/luvit` on Windows. #161

Closed xpol closed 8 years ago

xpol commented 8 years ago

F:\luvit>lit make lit://luvit/luvit lit version: 3.0.0 luvi version: v2.5.2 command: make lit://luvit/luvit fail: [string "bundle:libs/pkg.lua"]:30: module 'git' not found: no file 'bundle:libs/deps/git' no file 'bundle:libs/deps/git.lua' no file 'bundle:libs/deps/git/init.lua' no file 'bundle:libs/libs/git' no file 'bundle:libs/libs/git.lua' no file 'bundle:libs/libs/git/init.lua' no file 'bundle:deps/git' no file 'bundle:deps/git.lua' no file 'bundle:deps/git/init.lua' no file 'bundle:libs/git' no file 'bundle:libs/git.lua' no file 'bundle:libs/git/init.lua' no field package.preload['git'] no file '.\git.lua' no file 'F:\luvit\lua\git.lua' no file 'F:\luvit\lua\git\init.lua' no file 'C:\Lua\lua-5.1.5\x86\LuaRocks\2.2\lua\git.lua' no file 'C:\Lua\lua-5.1.5\x86\LuaRocks\2.2\lua\git\init.lua' no file 'C:\Lua\lua-5.1.5\x86\LuaRocks\systree\share\lua\5.1\git.lua' no file 'C:\Lua\lua-5.1.5\x86\LuaRocks\systree\share\lua\5.1\git\init.lua' no file '.\git.dll' no file 'F:\luvit\git.dll' no file 'F:\luvit\loadall.dll' no file 'C:\Lua\lua-5.1.5\x86\LuaRocks\systree\lib\lua\5.1\git.dll' stack traceback: [C]: in function 'require' [string "bundle:libs/pkg.lua"]:30: in main chunk

    [C]: in function 'require'
    [string "bundle:libs/core.lua"]:34: in main chunk
    [string "bundle:luvit-loader.lua"]:200: in function <[string "bundle:luvit-loader.lua"]:195>
    [C]: in function 'require'
    [string "bundle:commands/make.lua"]:2: in function <[string "bundle:commands/make.lua"]:1>
    [string "bundle:main.lua"]:52: in function <[string "bundle:main.lua"]:39>
    [C]: in function 'xpcall'
    [string "bundle:main.lua"]:39: in function <[string "bundle:main.lua"]:31>
xpol commented 8 years ago

I the problem is https://github.com/luvit/lit/archive/3.0.0.zip package have not include the deps/git module, becasue it is a submobule. Is it possible to use git subtree instead?

squeek502 commented 8 years ago

You're right, this section of the README will not work due to deps/git being a submodule:

Once you have luvi, building lit is simple:

curl -L https://github.com/luvit/lit/archive/master.zip > lit.zip
luvi lit.zip -- make lit.zip

The other instructions about building from source should work, though (git clone).

One thing that could be done would be to be add a way to get the most recent version of a package from the lit api, so that something like https://lit.luvit.io/packages/luvit/lit/v$LIT_VERSION.zip could be used in the README instructions instead of the github zip. Something like:

xpol commented 8 years ago

Yes, update the docs is good alternative.

creationix commented 8 years ago

Lit 3.0.3 with the new latest feature is released and deployed to lit.luvit.io.

squeek502 commented 8 years ago

@creationix Would changing the README build-from-source instructions to:

curl -L https://lit.luvit.io/packages/luvit/lit/latest.zip > lit.zip
luvi lit.zip -- make lit.zip

be an acceptable fix to this issue? The difference between that and the old instructions would be that the old instructions grabbed the latest HEAD rev of the repo, while the new ones will only grab the latest release tag.

creationix commented 8 years ago

Yes, that's fine. I release often enough that it won't be far behind anyway.

creationix commented 8 years ago

Especially as long as there is also instructions for using a recursive git clone for people who truly want latest HEAD from source.