Closed bjornbytes closed 6 years ago
+1
Relevant issues from when this was fixed in Luvit: https://github.com/luvit/lit/issues/222 and https://github.com/luvit/luvit/pull/1007
Another thought I had about this: Since this handle-closing behavior ended up being necessary for 2 of the big luv(i)-based apps, it seems like it could be a "sensible default" type of thing. Maybe luvi could provide this out of the box, expose a helper function for it, or at least document it somewhere.
When running lit on macOS, I noticed a problem where output was being truncated:
I didn't notice this behavior with the main luvit binary, and after some investigation found that it had some logic to close handles on exit so they get properly flushed. Copying this over to lit fixed the output truncation.