search

luvit / lit

Toolkit for developing, sharing, and running luvit/lua programs and libraries.
http://lit.luvit.io/
Apache License 2.0
245 stars 58 forks source link

add secure socket to dependencies of coro-net #302

Closed CoreBytee closed 2 years ago

CoreBytee commented 2 years ago

I added secure socket to the dependencies list of coro-net to prevent a error that im getting

Uncaught Error: [string "bundle:deps/require.lua"]:279: No such module 'secure-socket' in 'bundle:/deps/coro-net.lua' module 'secure-socket' not found: no field package.preload['secure-socket'] no file './secure-socket.lua' no file '/usr/local/share/luajit-2.1.0-beta3/secure-socket.lua' no file '/usr/local/share/lua/5.1/secure-socket.lua' no file '/usr/local/share/lua/5.1/secure-socket/init.lua' no file './secure-socket.so' no file '/usr/local/lib/lua/5.1/secure-socket.so' no file '/usr/local/lib/lua/5.1/loadall.so'

Also this is my first pull request so correct me if im wrong 😄

squeek502 commented 2 years ago

secure-socket is technically optional, as it's only needed for HTTPS; coro-net can work with plain HTTP without secure-socket being installed. It's specified in the optionalDependencies, but lit doesn't really know what that means--it's up to the user to install it if they need it.