check list for release v1.34.1 - Githubissues

luvit / luv

Bare libuv bindings for lua

Apache License 2.0

822 stars 185 forks source link

check list for release v1.34.1 #449

Closed zhaozg closed 4 years ago

zhaozg commented 4 years ago

[x] submodule update lua/luajit/libuv
[x] all test pass.
[x] missing new apis. Finished in https://github.com/luvit/luv/pull/450
- [x] uv_tty_set_vterm_state, in https://github.com/luvit/luv/pull/450/commits/b2c3ab0ae7866c5de00314d78622eb99c967ecb5, but all tty test miss
- [x] uv_tty_get_vterm_state, in https://github.com/luvit/luv/pull/450/commits/b2c3ab0ae7866c5de00314d78622eb99c967ecb5
- [x] uv_fs_mkstemp, in https://github.com/luvit/luv/pull/450/commits/4e667d386629818ddd1ffa54f57d68fea4b3d2f9
- [x] uv_random, in https://github.com/luvit/luv/pull/450/commits/3656f453588e2d3955d2113f718db31f699201ee
- [x] uv_sleep, in https://github.com/luvit/luv/pull/448/commits/fbac0b173ecba2c8f6dc2f177fc0f008d2ba61c6
[x] update version

And final, public tag

squeek502 commented 4 years ago

I'll work on the uv_random binding.

zhaozg commented 4 years ago

Release 1.34.1-0

SinisterRectus commented 4 years ago

Good stuff, and thank you for keeping the docs updated!

SinisterRectus commented 4 years ago

Luarocks release? https://luarocks.org/modules/creationix/luv

squeek502 commented 4 years ago

Looks like the deploy failed due to

The program 'luarocks' is currently not installed.

https://travis-ci.org/luvit/luv/jobs/638441659#L848-L851

Not sure why that would be.

EDIT: Whoops: https://github.com/luvit/luv/pull/453