luvit / luv

Bare libuv bindings for lua
Apache License 2.0
832 stars 187 forks source link

docs: make process_kill signum arg optional #666

Closed Bilal2453 closed 1 year ago

Bilal2453 commented 1 year ago

In Libuv, uv_process_kill takes a process and a signum, where the signum is required. In Luv although, in luv_parse_signal, if the input is not an integer and not a string, the default value of SIGTERM is used.

Effectively making signum an optional argument with the default string value sigterm.

squeek502 commented 1 year ago

The relevant code:

https://github.com/luvit/luv/blob/9e3c2320149884e5d809e9391f8580bb5f67bcdf/src/process.c#L302-L310

Bilal2453 commented 1 year ago

Seems like I forgot uv.kill in this PR.