search

luwes / craft-codemirror

Add the awesome in-browser code editor CodeMirror as a field type.
MIT License
18 stars 10 forks source link

Craft 4 Support #18

Closed internetztube closed 2 years ago

internetztube commented 2 years ago

First of all, thank you for this plugin. Now that Craft 4 is about to be released, do you plan to have the plugin ready by then?

davidhellmann commented 2 years ago

I'm also interested in this. Any plans here? : )

garycrane commented 2 years ago

+1 : Be good to see this in Craft 4 soon.

timeverts commented 2 years ago

Yes please!

green17 commented 2 years ago

Yes please too, great plugin thanks

lopugit commented 2 years ago

+1 this, I tried deploying my own package with the craft version simply set to 4 and now I get this error 

Fatal error: Declaration of luwes\codemirror\CodeMirror::createSettingsModel() must be compatible with craft\base\Plugin::createSettingsModel(): ?craft\base\Model in /Users/lopu/things/git/thirstcreative/craft4-starter-template-backend/vendor/luwes/craft3-codemirror/src/CodeMirror.php on line 74
wmdhosting commented 2 years ago

+5 :)

richhayler commented 2 years ago

Please bring this to Craft 4

bencresty commented 2 years ago

+1 Great plugin that must continue it's road to Craft 4!

engram-design commented 2 years ago

Just to chime in, we've added this to our Craft 3 migration project, as people are keen to see this plugin on Craft 4.

If you're no longer developing this plugin, we'd be happy to continue development at Verbb (including updating to Craft 4) - but just let us know if you've got plans to continue things and update to Craft 4! @luwes

luwes commented 2 years ago

hey guys, I don't have any plans to migrate or continue maintenance on this plugin. feel free to take over! cheers

davidhellmann commented 2 years ago

💰 sold to verbb! congratulations 🤣

But sounds great, thanks!

engram-design commented 2 years ago

@luwes Sounds good! If you want to transfer this repository to verbb or myself engram-design (you might have to add me as a collaborator first, then promote to admin), that'd be great, and we'll get this ported to Craft 4.

timeverts commented 2 years ago

Totally amazing news! Thanks Verbb and thanks @luwes for such a useful plugin.

petenice commented 2 years ago

Thanks in advance, I'm a big fan of this helpful field. Looking forward.

engram-design commented 2 years ago

@luwes Just wanted to check in about transferring this repo, so we can kick things off?

khamer commented 2 years ago

Just to add - I made a PR for Craft 4 support back in May - https://github.com/luwes/craft3-codemirror/pull/19 - that should be fine to use in the meanwhile, but happy to see this plugin brought into the Verbb fold.

luwes commented 2 years ago

Thanks @khamer and @engram-design!

Sorry for the misunderstanding, I didn't mean to transfer this repo. I merged @khamer 's PR adding Craft 4 support. thanks for your patience all!

engram-design commented 2 years ago

@luwes Works for me, thanks!

wmdhosting commented 2 years ago

just checking.... you merged PR for Craft 4 support.. but still not avaible in CRAFT 4 . store to download..